Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEND TIPS is not translated in Brave Panel for some locales #4868

Closed
btlechowski opened this issue Jun 12, 2019 · 4 comments
Closed

SEND TIPS is not translated in Brave Panel for some locales #4868

btlechowski opened this issue Jun 12, 2019 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Jun 12, 2019

Steps to Reproduce

  1. Change language to Norwegian
  2. Open a verified creator page
  3. Open Brave Panel

Not reproducible in: Polish

Actual result:

SEND TIPS is not translated in Brave Panel

image

Expected result:

SEND TIPS is translated in Brave Panel

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.66.88 Chromium: 75.0.3770.87 (Offizieller Build) beta (64-Bit)
Überarbeitung 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
Betriebssystem Windows 7 Service Pack 1 (Build 7601.24465)
Brave 0.68.36 Chromium: 75.0.3770.87 (Offisiell delversjon)nightly (64-bit)
Versjon 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Windows 7 Service Pack 1 (Build 7601.24465)

cc @brave/legacy_qa @bsclifton @NejcZdovc

@LaurenWags
Copy link
Member

LaurenWags commented Dec 10, 2019

Still occurs with 1.1.20 using Norwegian:

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Versjon 10.13.6 (bygg 17G5019)

Screen Shot 2019-12-10 at 5 40 42 pm

@btlechowski
Copy link
Author

This is still reproducible in 1.4.x. However in google translate Send tip translates to Send tips.
image

I don't know if this is proper way to translate it though.

Brave 1.4.95 Chromium: 80.0.3987.122 (Official Build) (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

Not reproducible in Polish and German.

@rebron
Copy link
Collaborator

rebron commented Jul 20, 2020

@btlechowski Is this still an issue with 1.11.97 and latest transifex pull or are we saying this is a wontfix based on last comment?

@btlechowski
Copy link
Author

btlechowski commented Jul 23, 2020

Still reproducible, but let's close it as wontfix based on #4868 (comment)

Brave 1.11.97 Chromium: 84.0.4147.89 (Offisiell delversjon) (64-bit)
Versjon 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

@btlechowski btlechowski removed QA/Test-Plan-Specified QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants