Tor process reaping on Windows

[darkdh]

Currently, tor process will be left alone when browser crash or killed on Windows.
Other platforms have different strategy to handle this situation
Mac: Terminate tor process in SuicideOnChannelErrorFilter
Linux: prctl(PR_SET_PDEATHSIG, SIGKILL) through LaunchOption.kill_on_parent_death

[GeetaSarvadnya]

Verification passed on

Brave | 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

• Verified the description from the issue Tor process reaping on Windows #1113 (comment)
• Opened a TOR window and confirmed that TOR process is shown/running in the windows Activity/processes monitoring
  
• Killed brave browser from process monitoring (where TOR window was already opened in brave), ensured that the TOR process is not running in Activity monitoring after killing brave browser.
• Verified the test plan from Tor control channel brave-core#4802

OS-chosen port for tor

Initial Tor window open:

Confirmed one of the ports listed matches .....\AppData\Local\BraveSoftware\Brave-Browser\User Data\tor\watch\controlport

• Verified that control port is different from the above step when close and reopen the tor window 2nd time

Tor initialization progress indicator

• Confirmed Tor tab shows initialization progress and status:
  

• Confirmed Tor tab is connected once the progress status is 100 %
  

• Verified that tab keeps spinning when https://check.torproject.org/ is opened in an NTP as soon as TOR window is opened
  

• Verified the connected Tor network on https://check.torproject.org/ when tor is connected to the tor network
  

Tor process crash handling

Killed/End the Tor process

Confirmed another Tor process launched 1s later.
Confirmed able to go back to the open Tor window, visit check.torproject.org and connect to Tor network.

Tor launcher crash handling

Killed Tor Launcher from Brave's Task Manager:

Went back to the open Tor tab and confirmed I was still connected to Tor network (did a hard refresh and confirmed I got a new IP address.

Closed Tor window and opened a new one. Confirmed new Process ID and able to navigate to check.torproject.org successfully: