Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Text on Brave Desktop info card looks like link #11326

Closed
srirambv opened this issue Aug 19, 2020 · 6 comments · Fixed by brave/brave-core#6517
Closed

[Android] Text on Brave Desktop info card looks like link #11326

srirambv opened this issue Aug 19, 2020 · 6 comments · Fixed by brave/brave-core#6517
Assignees
@deeppandya
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.13.x - Release #2

Comments

@srirambv
Copy link
Contributor

Description

Text on Brave Desktop info card looks like link

Steps to reproduce

  1. Follow steps from https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/Mobile-onboarding-v2?node-id=697%3A5848

Actual result

brave.com on the message looks like a link.
image

Expected result

Should probably have a different colour to make it obvious that its not a link and can't be tapped

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? NA

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version:10

Brave version

1.14.44

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality labels Aug 19, 2020
@srirambv srirambv added this to the 1.13.x - Beta milestone Aug 19, 2020
@bsclifton bsclifton added the priority/P4 Planned work. We expect to get to it "soon". label Aug 27, 2020
@bsclifton bsclifton removed this from the 1.13.x - Release milestone Aug 27, 2020
@bsclifton
Copy link
Member

Implementation matches spec. @jamesmudgett @karenkliu should anything be done to make brave.com not look like a link? or close as wontfix?

@deeppandya deeppandya mentioned this issue Aug 27, 2020
Merged
32 tasks
@deeppandya
Copy link

Implementation matches spec. @jamesmudgett @karenkliu should anything be done to make brave.com not look like a link? or close as wontfix?

@bsclifton i have removed brave.com as link because it's not doing anything on tap. brave/brave-core#6517

@bsclifton
Copy link
Member

bsclifton commented Aug 27, 2020 •
edited
Loading

@deeppandya OK great 😄 Assigned you and put as In progress on the project board. When PR is merged, you can assign the milestone (1.15.x) and do the uplifts to 1.13/1.14

@karenkliu
Copy link

@deeppandya As a reminder we talked setting brave.com to be the same color as the rest of the text because it's not a link over here #10571 (comment)

@deeppandya
Copy link

@deeppandya As a reminder we talked setting brave.com to be the same color as the rest of the text because it's not a link over here #10571 (comment)

@karenkliu it's done. And I have already created a PR for this. So it should be nightly soon.

@deeppandya deeppandya added this to the Android 1.13.x - Release milestone Aug 28, 2020
@srirambv srirambv mentioned this issue Aug 31, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83

  • Verified text on cross-platform promotion doesn't look like a link

Verification passed on OnePlus 6T with Android 10 running 1.13.83

  • Verified text on cross-platform promotion doesn't look like a link

@srirambv srirambv mentioned this issue Sep 2, 2020
Closed
31 tasks
@anthonypkeane anthonypkeane mentioned this issue Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13.x - Release #2
Development

Successfully merging a pull request may close this issue.

Update cross promo modal brave/brave-core
4 participants
@karenkliu @bsclifton @deeppandya @srirambv