Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Sign setup.exe #11378

Closed
jumde opened this issue Aug 21, 2020 · 3 comments · Fixed by brave/brave-core#6436
Closed

[Desktop] Sign setup.exe #11378

jumde opened this issue Aug 21, 2020 · 3 comments · Fixed by brave/brave-core#6436
Assignees
@jumde
Labels
OS/Desktop OS/Windows QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.13.x - Release #2

Comments

@jumde
Copy link
Contributor

jumde commented Aug 21, 2020 •
edited
Loading

Description

setup.exe is unsigned.

Test Plan:

Specified here: brave/brave-core#6436
@jumde jumde mentioned this issue Aug 21, 2020
Merged
32 tasks
@jumde jumde changed the title [Desktop] Sign the stub installer [Desktop] Sign setup.exe Aug 22, 2020
@jumde jumde self-assigned this Aug 22, 2020
@jumde jumde added this to the 1.15.x - Nightly milestone Aug 26, 2020
@brave-builds brave-builds mentioned this issue Aug 30, 2020
Merged
4 tasks
@jumde jumde mentioned this issue Aug 30, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor

srirambv commented Sep 4, 2020

@kjozwiak should this be part of https://github.com/brave/brave-browser/milestone/136 which is Android milestone? Should probably move it to Desktop HF milestone

@jumde
Copy link
Contributor Author

jumde commented Sep 5, 2020

@srirambv - This is windows only. Doesn't affect Android.

This was referenced Sep 9, 2020
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

Verification passed on Windows 10 x64 using


Brave | 1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


c:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64>bravesign.exe verify /pa "C:\Program Files\BraveSoftware\Brave-Browser\Application\85.1.13.86\Installer\setup.exe"
File: C:\Program Files\BraveSoftware\Brave-Browser\Application\85.1.13.86\Installer\setup.exe
Index  Algorithm  Timestamp
========================================
0      sha256     Authenticode

Successfully verified: C:\Program Files\BraveSoftware\Brave-Browser\Application\85.1.13.86\Installer\setup.exe

image

c:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64>bravesign.exe verify /pa "C:\Program Files\BraveSoftware\Brave-Browser\Application\85.1.13.86\chrome.dll"
File: C:\Program Files\BraveSoftware\Brave-Browser\Application\85.1.13.86\chrome.dll
Index  Algorithm  Timestamp
========================================
0      sha256     Authenticode

Successfully verified: C:\Program Files\BraveSoftware\Brave-Browser\Application\85.1.13.86\chrome.dll

image

c:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64>bravesign.exe verify /pa "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe"
File: C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Index  Algorithm  Timestamp
========================================
0      sha256     Authenticode

Successfully verified: C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe

image

@kjozwiak kjozwiak mentioned this issue Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
OS/Desktop OS/Windows QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.13.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fix #11378: Sign setup.exe brave/brave-core
5 participants
@jumde @kjozwiak @srirambv @GeetaSarvadnya and others