Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11378: Sign setup.exe (uplift to 1.13.x) #6536

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Fix #11378: Sign setup.exe (uplift to 1.13.x) #6536

merged 1 commit into from
Sep 1, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 30, 2020 •
edited by kjozwiak
Loading

Uplift of #6436
Resolves brave/brave-browser#11378

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@jumde jumde requested a review from a team August 30, 2020 22:06
kjozwiak
kjozwiak approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6436 (comment), #6436 (comment) and #6436 (comment).

@kjozwiak kjozwiak merged commit 7b102dc into 1.13.x Sep 1, 2020
@kjozwiak kjozwiak deleted the pr6436_sign_uninstaller_1.13.x branch September 1, 2020 14:46
@kjozwiak kjozwiak added this to the Android 1.13.x Release milestone Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.x Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@jumde @kjozwiak @brave-browser-releases