-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Remove bind_util #11471
Labels
Milestone
Comments
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Aug 31, 2020
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Aug 31, 2020
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Aug 31, 2020
Verified passed with
Verified test plan from brave/brave-core#6548 Confirmed able to claim promotion (UGP grant on staging) via panel, NTP widget, and brave://rewards pageConfirmed brave://rewards-internals showed data from above contributions (1 time tips, recurring tips, AC) as expectedConfirmed able to restore a wallet with waiting ad grant and then confirmed I could claim that ad grantVerification passed on
Confirmed able to claim promotion (UGP grant on staging) via panel, NTP widget, and brave://rewards pageConfirmed brave://rewards-internals showed data from above contributions (1 time tips, recurring tips, AC) as expectedConfirmed able to restore a wallet with waiting ad grant and then confirmed I could claim that ad grantVerification passed on
Confirmed able to claim promotion (UGP grant on staging) via panel, NTP widget, and brave://rewards pageConfirmed able to do 1 time tips, recurring tips, and AC using promotion![image](https://user-images.githubusercontent.com/34715963/93967755-3ec8e200-fd68-11ea-9e99-0783dc49a8a6.png) ![image](https://user-images.githubusercontent.com/34715963/93967816-5902c000-fd68-11ea-87a5-3ba2a3aa4dca.png) ![image](https://user-images.githubusercontent.com/34715963/93967851-7041ad80-fd68-11ea-9c40-4aea354f3eaa.png) ![image](https://user-images.githubusercontent.com/34715963/93967879-7f286000-fd68-11ea-94c1-db5b9e882841.png)Confirmed brave://rewards-internals showed data from above contributions (1 time tips, recurring tips, AC) as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bind util was created as we didn't know how to handle mojo pointers. Now we have a way with shared pointers. You can see example here https://github.com/brave/brave-core/blob/d3487abc76a2760ac1614e03b6f66dd78f4d62ca/vendor/bat-native-ledger/src/bat/ledger/internal/promotion/promotion.cc#L179
The text was updated successfully, but these errors were encountered: