Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields menu text is not visible #1150

Closed
DBLouis opened this issue Sep 16, 2018 · 28 comments
Closed

Shields menu text is not visible #1150

DBLouis opened this issue Sep 16, 2018 · 28 comments
Labels
bug closed/invalid feature/shields The overall Shields feature in Brave. OS/Linux priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@DBLouis
Copy link

DBLouis commented Sep 16, 2018

Description

Text in shields menu is not visible (see screenshot)

Steps to Reproduce

  1. Download latest dev release and run it
  2. Go to any website
  3. Open shields menu

Actual result:

brave_shields_invisible

Reproduces how often:

Always

Brave version

v0.55.4

Reproducible on current release:

No

Additional Information

Void Linux (Kernel 4.18)
i3 window manager

I have tried dark/light classic and gtk+ themes, changing the system gtk theme.
If not all fonts are packaged with the release maybe I am missing one.
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. OS/Linux labels Sep 17, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Sep 17, 2018
@jaromero
Copy link

jaromero commented Oct 16, 2018 •
edited
Loading

I haven't looked too much in depth into this, but it seems that the text is just not there at all, at least when inspecting the popup with the Dev Tools.

screenshot from 2018-10-16 11-52-55

On this screenshot I just manually added the text into the <option> element via Dev Tools. Notice how the <option> elements from the other <select> earlier are completely empty.

@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 31, 2018
@tildelowengrimm
Copy link
Contributor

@srirambv Could you see if this is fixed on new builds?

@DBLouis
Copy link
Author

DBLouis commented Oct 31, 2018

Still not working in v0.57.3

@warwickmm
Copy link

Same here, on Linux (4.18.16) with Cinnamon desktop environment.

@DBLouis
Copy link
Author

DBLouis commented Nov 6, 2018

In v0.57.6 the menu is prettier but still no text

@tildelowengrimm tildelowengrimm added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 7, 2018
@MafiaInc
Copy link

MafiaInc commented Nov 14, 2018 •
edited
Loading

I have the same issue on Version 0.56.12 Chromium: 70.0.3538.77 (Official Build) unknown (64-bit). Running KDE on Arch Linux 4.19.1-arch1-1-ARCH #1 SMP PREEMPT Sun Nov 4 16:49:26 UTC 2018 x86_64 GNU/Linux
image

@MafiaInc
Copy link

In additional I have some strange i18n prefixes on the text in "Brave Rewards" menu:
image

I'm not sure whether it worth opening separate issue for that one? :)

@srirambv
Copy link
Contributor

@MafiaInc Please log an another issue for the rewards panel with translation strings. Also please mention the OS details. This could be specific to Arch based distros. I don't see this problem on Ubuntu
image

@MafiaInc
Copy link

@srirambv Issue: #2138 opened

@jficz
Copy link

jficz commented Nov 19, 2018 •
edited
Loading

I can confirm this issue on Arch. Version 0.56.12 Chromium: 70.0.3538.77 (Official Build) unknown (64-bit).

This somehow feels like a font problem - what font is used on the Shield?

Edit: looks like Poppins font is used. However, installing the font changed nothing.

In Inspect it does seem there is no text at all.

@DBLouis
Copy link
Author

DBLouis commented Nov 21, 2018

Still in 0.58.9

@bartduisters
Copy link

Still in 0.56.15-1

@mdkcore0
Copy link

same thing here (Slackware 14.2, Version 0.57.18 Chromium: 71.0.3578.80 (Official Build) unknown (64-bit))
shields

@cezaraugusto
Copy link
Contributor

@posix4e do you have an idea of what can be causing this? this seems related to arch based distros only. other distributions doesn't seem to be affected. can't repro on ubuntu for example

@petemill
Copy link
Member

This strikes me as something going wrong with our translation layer (either JS or outside) and not a font issue since there is some text on the page, the text that is hidden is not in the DOM at all, and the text that is displaying Ok is non-translated (domain names and numbers).

@jficz
Copy link

jficz commented Dec 13, 2018 •
edited
Loading

I've tried to manually extract and run Brave from the Ubuntu package (v 0.57.18) on my Arch and the shield works there so apparently there is something wrong with the plain zip release.

@DBLouis
Copy link
Author

DBLouis commented Dec 13, 2018

Still in v0.59.6

@mdkcore0
Copy link

@posix4e do you have an idea of what can be causing this? this seems related to arch based distros only. other distributions doesn't seem to be affected. can't repro on ubuntu for example

just to say, I'm on Slackware and it doesn't work either.

I've tried to manually extract and run Brave from the Ubuntu package (v 0.57.18) on my Arch and the shield works there so apparently there is something wrong with the plain zip release.

yup, I'm running it from the zip as well (the slackware package is just a repackage of it too).

@ghost
Copy link

ghost commented Dec 18, 2018 •
edited by ghost
Loading

Running Brave on Solus from zip as well, still no fonts on Shield, on last stable, beta and dev Brave versions

@kirkins
Copy link

kirkins commented Dec 23, 2018 •
edited
Loading

I'm also seeing the i18n issue on Ubuntu 18.04

Installed via the zip download.

@eljuno
Copy link

eljuno commented Dec 27, 2018

+1 from Community https://community.brave.com/t/bad-colours-on-brave-extension/41076?u=eljuno

@RainmakerRaw
Copy link

I had to uninstall Brave on Arch for this reason, also. The issue persists in latest brave-bin (0.58.18-1) and brave-dev-bin (0.60.6-1). Using Cinnamon 4.0.8 with Mutter.

@cezaraugusto
Copy link
Contributor

un-assigning myself as this is platform specific and I won't be able to help much. cc @posix4e who could answer better regarding Linux-related issues

@cezaraugusto cezaraugusto removed their assignment Jan 17, 2019
@rjocoleman
Copy link

This appears to be a packaging issue in the zip version. Looking at the various issues and threads I didn't see any definition on what's going on, so I've narrowed it down, further details here: https://community.brave.com/t/brave-shield-ui-bug/33570/63

I hope this helps resolve it!

@whezzel
Copy link

whezzel commented Jan 23, 2019 •
edited
Loading

@rjocoleman great find. I have just tested this with brave-beta-0.59.28 on my arch install. Extracting the resources from the debian package and inserting them into the zip distribution, fixes this issue.
screenshot from 2019-01-23 15-14-14
screenshot from 2019-01-23 15-14-32

@srirambv srirambv mentioned this issue Jan 25, 2019
Closed
@cezaraugusto
Copy link
Contributor

cc @bbondy your assumption re packaging is correct. not sure who could take this

related #3104

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 9, 2019

+1 https://www.reddit.com/r/brave_browser/comments/aot2j4/brave_shield_display_error/

@simonhong
Copy link
Member

Duplicated with #3399 and fixed by #3446.

@simonhong simonhong added this to the Dupe / Invalid / Not actionable milestone Mar 1, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug closed/invalid feature/shields The overall Shields feature in Brave. OS/Linux priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests