Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations missing on Arch based distros #2138

Closed
MafiaInc opened this issue Nov 14, 2018 · 4 comments
Closed

Translations missing on Arch based distros #2138

MafiaInc opened this issue Nov 14, 2018 · 4 comments

Comments

@MafiaInc
Copy link

Description

Labels and text in Brave Rewards menu appears with i18n prefixes.

Steps to Reproduce

  1. Open any site
  2. Click on Brave Rewards button located in the end of the location bar
  3. Observe the text on labels and buttons

Actual result:

image

Expected result:

To not have "i18n" prefixes on text.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.56.12 Chromium: 70.0.3538.77 (Official Build) unknown (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
JavaScript V8 7.0.276.32
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
Command Line /usr/lib/brave-bin/brave --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor,AutofillSaveCardSignInAfterLocalSave,kAutofillServerCommunication --flag-switches-begin --flag-switches-end --
Executable Path /usr/lib/brave-bin/brave
Profile Path /home/marto/.config/BraveSoftware/Brave-Browser/Default
Variations ...

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes, this is

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No, not site specific.
  • Is the issue reproducible on the latest version of Chrome?
    Not relevant for Chrome

Additional Information

More system details:
Operating System: Arch Linux
KDE Plasma Version: 5.14.3
Qt Version: 5.11.2
KDE Frameworks Version: 5.52.0
Kernel Version: 4.19.1-arch1-1-ARCH
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-5300U CPU @ 2.30GHz
Memory: 7,7 GiB of RAM

@srirambv srirambv added this to the 1.x Backlog milestone Nov 14, 2018
@srirambv srirambv changed the title Text in Brave Reward menu is prefixed with 'i18n' on Linux Translations missing on Arch based distros Nov 14, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 16, 2018
@NejcZdovc
Copy link
Contributor

cc @bbondy will this be fixed with the latest language fix?

@bbondy
Copy link
Member

bbondy commented Nov 22, 2018

no

@droidman
Copy link

If you compile brave on arch the bug is fixed.

@srirambv
Copy link
Contributor

This should be fixed already
image
image

This is fixed on the community maintained arch bin. Closing the issue as fixed

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 24, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants