Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] removing previous rewards.log from "session_profiles/Tor Profile" #11644

Closed
kjozwiak opened this issue Sep 10, 2020 · 4 comments
Closed
Assignees

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 10, 2020

Description

If a user has previously exported logs via brave://rewards-internals and has use Tor, they still might have a copy in the following directory:

* /BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/

This was partially fixed via #11260 but didn't cover the /session_profiles/Tor Profile/ case.

Steps to Reproduce

  1. launch a version of brave before Disable logs brave-core#6439 was merged
  2. enable rewards
  3. go into /BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/ and you should see Rewards.log
  4. update to a new version and you'll notice the Rewards.log is removed from ``/BraveSoftware/Brave-Browser-Nightly/Default/but not from/BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/`.

Actual result:

Screen Shot 2020-09-09 at 10 39 34 PM

Expected result:

Rewards.log should be removed from /BraveSoftware/Brave-Browser-Nightly/Default/session_profiles/Tor Profile/

Reproduces how often:

100% reproducible using the STR mentioned above.

Brave version (brave://version info)

Brave | 1.16.4 Chromium: 85.0.4183.102 (Official Build) nightly (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @diracdeltas @rebron @NejcZdovc @jsecretan @tmancey for prioritization.

@GeetaSarvadnya
Copy link

Reproduced in windows 10 x64 - 1.13.86

@btlechowski
Copy link

Reproduced on

Brave 1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS

@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 24, 2020
@mkarolin
Copy link
Contributor

mkarolin commented Dec 5, 2022

@kjozwiak @Miyayes do you think this is still actionable? I can't even install a version pre STR 1 that is able to join Rewards at this point. Also, I don't believe we create Default/session_profiles/Tor Profile/ any more either. WDYT?

@kjozwiak
Copy link
Member Author

kjozwiak commented Jan 9, 2023

@kjozwiak @Miyayes do you think this is still actionable? I can't even install a version pre STR 1 that is able to join Rewards at this point. Also, I don't believe we create Default/session_profiles/Tor Profile/ any more either. WDYT?

@mkarolin yup, lets close this off. As you pointed out, we don't even create a Tor Profile folder under Sessions anymore. I doubt anyone is going to be downloading the older version mentioned above. Even if they do, they'll have issues enabling rewards as it was refactored a bunch of times between then and now. @Miyayes going to close this off, please re-open if you feel differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants
@tmancey @kjozwiak @rebron @NejcZdovc @btlechowski @GeetaSarvadnya @mkarolin and others