Disable logs

[NejcZdovc]

Resolves brave/brave-browser#11260

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

plan 1:

• enable rewards
• make sure that there is no Rewards log file in profile

plan 2:

• go to master and start browser
• enable rewards
• make sure that logs are generated and close browser
• go to this PR
• start browser
• make sure that file is deleted and no further logs are persisted on disk

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[tmancey]

Please see inline comments

[tmancey]

nit: !should_persist_logs_ within a separate if as conditions are not related

[tmancey]

LGTM++

[kylehickinson]

iOS currently doesn't need to implement this, but when it does, are we talking deleting all logs? Is this like a clear-all?

[NejcZdovc]

@kylehickinson just removing Rewards.log file (at least this is how we name it on desktop).

[kylehickinson]

Gotcha, which is where all logs are stored on desktop I presume? When we have persisted logs enabled, we have multiple logs files per day. So this would essentially delete all persisted rewards logs

[NejcZdovc]

@kylehickinson yeah on desktop we only have one file. and if that is the case on iOS yes you need to delete all of them

[kjozwiak]

Verification PASSED on macOS 10.15.6 x64 using the following builds:

Brave | 1.14.51 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.15.6 (Build 19G73)

Using the STR/Cases outlined via #6439 (comment), went through the following:

Case 1:

• downloaded/installed 1.14.51 CR: 85.0.4183.69
• enabled rewards via the rewards panel (double checked brave://rewards)
• checked and ensured that Rewards.log wasn't created under ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Nightly/Default
• ensured that Clear, Refresh and Download full log doesn't work under brave://rewards-internals and doesn't crash (checked brave://crashes)

Case 2:

• Updated my personal profile which was on 1.14.48 CR: 85.0.4183.69 to 1.14.51 CR: 85.0.4183.69
• ensured that Rewards.log was removed from ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Nightly/Default
• ensured there's no crashes under brave://crashes after upgrading
• ensured that Clear, Refresh and Download full log doesn't work under brave://rewards-internals and doesn't crash (checked brave://crashes)

[kjozwiak]

@kylehickinson do we need a separate issue for iOS?

[kylehickinson]

@kjozwiak no, iOS never wrote rewards logs to disk in any live version so we should be OK. Rewards Internals for iOS also removed logs before it merged.

May just want to make a note on the Rewards Internals issue

[srirambv]

@NejcZdovc can you please add steps for Android. Issue is marked to verify on Android as well

[NejcZdovc]

@srirambv because you can't check if file is there or not I would just make sure if you go to internals page and click download that nothing happens/file is blank