Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logs (uplift to 1.13.x) #6441

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Disable logs (uplift to 1.13.x) #6441

merged 1 commit into from
Aug 19, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 18, 2020

Uplift of #6439
Resolves brave/brave-browser#11260

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.13.x - Beta milestone Aug 18, 2020
@NejcZdovc NejcZdovc requested a review from a team August 18, 2020 14:16
@NejcZdovc NejcZdovc self-assigned this Aug 18, 2020
@NejcZdovc NejcZdovc removed the request for review from kylehickinson August 18, 2020 14:17
@kjozwiak
Copy link
Member

Restarting all platforms using Build with Parameters as they all failed due to the following:

hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: NODE_LABEL for class: WorkflowScript

@NejcZdovc NejcZdovc force-pushed the disable-logs-1.13 branch 2 times, most recently from bda65e4 to 8416dab Compare August 19, 2020 05:04
@kjozwiak
Copy link
Member

Restarted Android via https://ci.brave.com/job/brave-core-build-pr-android/job/PR-6441/5/ as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-disable-logs-1.13-android/3/execution/node/196/log/.

Restarting Linux via https://ci.brave.com/job/pr-brave-browser-disable-logs-1.13-linux/4/ as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-disable-logs-1.13-linux/3/execution/node/199/log/.

01:33:19  FAILED: obj/brave/components/brave_rewards/test/brave_rewards_unit_tests/redeem_unblinded_token_unittest.o 

@kjozwiak
Copy link
Member

test-browser failed on Win x64 due to SpeedReaderBrowserTest.SmokeTest failing as per https://ci.brave.com/job/pr-brave-browser-disable-logs-1.13-windows/4/execution/node/216/log/. However this is a known intermittent failure/issue and doesn't block uplift.

03:48:40  [  FAILED  ] SpeedReaderBrowserTest.SmokeTest, where TypeParam =  and GetParam() =  (3355 ms)
03:48:40  
03:48:40  [603/603] SpeedReaderBrowserTest.SmokeTest (3519 ms)
03:48:40  1 test failed:
03:48:40      SpeedReaderBrowserTest.SmokeTest (../../brave/browser/speedreader/speedreader_browsertest.cc:71)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6439 (comment).

@kjozwiak kjozwiak merged commit 57f3b77 into 1.13.x Aug 19, 2020
@kjozwiak kjozwiak deleted the disable-logs-1.13 branch August 19, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants