-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-contribute list should only contain included publishers #1175
Comments
Is there a privacy issue with this one @diracdeltas |
what is sent in the fetch? (and what is the response) |
@rebron @diracdeltas sorry for the confusion, there was not a "fetch" involved with this one (no http requests/server calls). This was just an issue with the auto-contribute list grabbed from the native ledger containing both included/excluded publishers. I've updated the issue title. cc: @NejcZdovc |
@ryanml thanks for clarifying! |
Auto-Contribute list only contains included pubs by default numExcludedSites is now part of the AppState and passed as a modalContribute prop
@ryanml is there anything QA can do here in terms of verification? There's not much information here in terms of cases/test plans that QA can follow. If there's nothing required here, can you please mark this as |
Verification Passed on
Verification passed on
Used test plan from brave/brave-core#475 Verified passed with
Used test plan from brave/brave-core#475 |
Test Plan
See brave/brave-core#475
Count of excluded publishers should be a part of the state, and not filtered for on the client side
The text was updated successfully, but these errors were encountered: