Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] bubbles do not show properly on initial display #11838

Closed
LaurenWags opened this issue Sep 24, 2020 · 10 comments
Closed

[Desktop] bubbles do not show properly on initial display #11838

LaurenWags opened this issue Sep 24, 2020 · 10 comments
Labels
bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/translate OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes regression release-notes/include

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 24, 2020

Test plan

Issue should be fixed as part of Chromium 87

If everything looks good, test steps are below under Steps to Reproduce

Description

Modals are not displaying properly on initial load, however if you close and reopen the modal does show as expected.

Example:
When you navigate to a site in a different language and you see the offer to translate popup (the one to install Google Translate), the popup does not display correctly on initial load. If you click away and then reopen the popup it does display correctly.

Example 2:
Password modals show oddly as well. If you close/reopen by clicking on the "key" icon it shows as expected.

Does not reproduce with 1.14.x (C85) version.

Steps to Reproduce

Scenario 1:

  1. Clean profile 1.15.x
  2. Navigate to a site in a different language (ex. if your OS is set to English, try interia.pl or 3zsistemi.si)
  3. You get the offer to translate popup but the colors/styling is incorrect

Actual result:

Dark:
1 15 x - initial

Light:
light

Expected result:

Should show as it does in 1.14.x which is also how it shows if you click away and then reopen this popup manually from the URL bar:
Dark
reload dark

Light
reload light

Scenario 2:

  1. Clean profile 1.15.x
  2. Navigate to a site where you need to login.
  3. Enter login info/login
  4. You get the offer to save your password but the colors/styling is incorrect

Actual result:

Dark:
Screen Shot 2020-09-24 at 10 46 46 AM

Light:
Screen Shot 2020-09-22 at 11 18 59 PM

Expected result:

Should show as it does in 1.14.x which is also how it shows if you close and then reopen this popup manually from the URL bar:
Screen Shot 2020-09-24 at 10 51 04 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.15.60 Chromium: 86.0.4240.42 (Official Build) dev (x86_64)
Revision 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS macOS Version 10.14.6 (Build 18G3020)
Brave 1.16.35 Chromium: 86.0.4240.42 (Official Build) nightly (x86_64)
Revision 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no using 1.14.x C85
  • Can you reproduce this issue with the beta channel? yes using 1.15.x C86
  • Can you reproduce this issue with the nightly channel? yes using 1.16.x C86

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mkarolin @rebron @bsclifton

@btlechowski
Copy link

Not reproducible on Linux

Brave 1.15.60 Chromium: 86.0.4240.42 (Official Build) dev (64-bit)
Revision 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS Ubuntu 18.04 LTS

image
image

Not reproducible on Windows

Brave 1.15.60 Chromium: 86.0.4240.42 (Official Build) dev (64-bit)
Revision 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

image

@LaurenWags LaurenWags changed the title [Desktop] offer to translate popup does not display correctly on initial site load [Desktop] modals do not show properly on initial display Sep 24, 2020
@kjozwiak
Copy link
Member

Reproduced the issue with the Save Password modal as well. Example:

Screen Shot 2020-09-22 at 11 18 59 PM

Used the following build to reproduce:

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

@btlechowski
Copy link

Not reproducible with Passwords modal on Linux

Brave 1.15.60 Chromium: 86.0.4240.42 (Official Build) dev (64-bit)
Revision 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS Ubuntu 18.04 LTS

image

@kjozwiak kjozwiak changed the title [Desktop] modals do not show properly on initial display [Desktop] bubbles do not show properly on initial display Sep 24, 2020
@bsclifton
Copy link
Member

Assigned @petemill who is checking this out now 😄

@petemill
Copy link
Member

@petemill petemill added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix regression labels Sep 25, 2020
@petemill
Copy link
Member

Note STR in upstream bug around the inactive colors of the "reset" button in the zoom dialog after pressing cmd-+

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 29, 2020
@LaurenWags
Copy link
Member Author

Note - issue for light them was broken out into a separate issue per today's discussion: #11916

@bsclifton
Copy link
Member

Issue has been fixed upstream in Chromium 88; they're working on uplift to Chromium 87
https://bugs.chromium.org/p/chromium/issues/detail?id=1112244#c19

We should be able to check this with 1.17 if the patch is accepted 😄

@LaurenWags
Copy link
Member Author

labelling as QA/Blocked until patch mentioned in #11838 (comment) is included in 1.17.x.

@rebron
Copy link
Collaborator

rebron commented Nov 16, 2020

Verified and looks good on:

Brave 1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS macOS Version 11.0.1 (Build 20B29)

Light theme -
Screen Shot 2020-11-16 at 11 01 43 AM

Dark theme -
Screen Shot 2020-11-16 at 11 01 23 AM


Verified passed with

Brave | 1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
-- | --
Revision | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS | macOS Version 10.14.6 (Build 18G6042)

Verified scenarios 1 and 2 from description using both dark and light themes.

Dark Screen Shot 2020-11-16 at 2 57 41 PM Screen Shot 2020-11-16 at 2 58 01 PM Screen Shot 2020-11-16 at 2 58 34 PM
Light Screen Shot 2020-11-16 at 2 59 54 PM Screen Shot 2020-11-16 at 3 00 06 PM Screen Shot 2020-11-16 at 3 00 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/translate OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes regression release-notes/include
Projects
None yet
Development

No branches or pull requests

6 participants