-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] bubbles do not show properly on initial display #11838
Comments
Not reproducible on Linux
Not reproducible on Windows
|
Reproduced the issue with the Used the following build to reproduce:
|
Not reproducible with Passwords modal on Linux
|
Assigned @petemill who is checking this out now 😄 |
This is an upstream bug https://bugs.chromium.org/p/chromium/issues/detail?id=1112244#c3 |
Note STR in upstream bug around the inactive colors of the "reset" button in the zoom dialog after pressing cmd-+ |
Note - issue for light them was broken out into a separate issue per today's discussion: #11916 |
Issue has been fixed upstream in Chromium 88; they're working on uplift to Chromium 87 We should be able to check this with 1.17 if the patch is accepted 😄 |
labelling as |
Verified and looks good on:
Verified passed with
Verified scenarios 1 and 2 from description using both dark and light themes. |
Test plan
Issue should be fixed as part of Chromium 87
If everything looks good, test steps are below under
Steps to Reproduce
Description
Modals are not displaying properly on initial load, however if you close and reopen the modal does show as expected.
Example:
When you navigate to a site in a different language and you see the offer to translate popup (the one to install Google Translate), the popup does not display correctly on initial load. If you click away and then reopen the popup it does display correctly.
Example 2:
Password modals show oddly as well. If you close/reopen by clicking on the "key" icon it shows as expected.
Does not reproduce with 1.14.x (C85) version.
Steps to Reproduce
Scenario 1:
Actual result:
Dark:
Light:
Expected result:
Should show as it does in 1.14.x which is also how it shows if you click away and then reopen this popup manually from the URL bar:
Dark
Light
Scenario 2:
Actual result:
Dark:
Light:
Expected result:
Should show as it does in 1.14.x which is also how it shows if you close and then reopen this popup manually from the URL bar:
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @mkarolin @rebron @bsclifton
The text was updated successfully, but these errors were encountered: