-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinanceAPIBrowserTest.NewTabHasBinanceAPIAccess crashes if ASAN is enabled #11895
Comments
This was referenced Sep 29, 2020
23 tasks
iefremov
added a commit
to brave/brave-core
that referenced
this issue
Dec 1, 2020
Fixes brave/brave-browser#11895 Passing char* to Base64Encode was triggering an implicit construction of StringPiece from a "string" which wasn't null terminated. Using Base64Encode version that takes a base::span will make us safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: