-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct navigations are wrongly exempted from the query string filter #11924
Comments
Reproduced in |
Thanks @GeetaSarvadnya and @btlechowski for catching this oversight in the tests I added. This is in fact a logic error which we will need to fix on Beta too. |
…rave-browser#11924) This regression was introduced in 9208797.
As mentioned in #11930 (comment), in addition to copy/pasting the URL in the URL bar, choosing "Open the link in a private window" also lead to the query string not getting filtered. |
Verified passed with
Verified test plan from brave/brave-core#6741 Verified STR from description including all listed parameters. Verification passed on
Verified test plan from brave/brave-core#6741 Verified STR from description including all listed parameters. Verification passed on
Verified test plan from brave/brave-core#6741 Verified STR from description including all listed parameters. |
Verification passed on OnePlus 6T with Android 10 running 1.16.69 x64 build
Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build
|
This is a regression introduced in 1.16.x. Not reproducible on 1.15.x, 1.14.x
Steps to Reproduce
https://brave.com/?dclid=1
Another link with regressed parameters:
https://brave.com/?vero_id=1234&vero_conv=abc
Regressed parameters:
"fbclid", "gclid", "msclkid", "mc_eid",
"dclid",
"yclid",
"_hsenc", "__hssc", "__hstc", "__hsfp", "hsCtaTracking"
Actual result:
dclid=1
parameter is not filtered outExpected result:
dclid=1
parameter is filtered outReproduces how often:
Easily reproduced
Desktop Brave version:
Reproducible on
Not reproducible on
cc @brave/legacy_qa @fmarier @rebron @bsclifton
The text was updated successfully, but these errors were encountered: