Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct navigations are wrongly exempted from the query string filter #11924

Closed
btlechowski opened this issue Sep 30, 2020 · 5 comments · Fixed by brave/brave-core#6741
Closed
Assignees
Labels

Comments

@btlechowski
Copy link

btlechowski commented Sep 30, 2020

This is a regression introduced in 1.16.x. Not reproducible on 1.15.x, 1.14.x

Steps to Reproduce

  1. Clean profile
  2. Open https://brave.com/?dclid=1

Another link with regressed parameters:
https://brave.com/?vero_id=1234&vero_conv=abc

Regressed parameters:
"fbclid", "gclid", "msclkid", "mc_eid",
"dclid",
"yclid",
"_hsenc", "__hssc", "__hstc", "__hsfp", "hsCtaTracking"

Actual result:

dclid=1 parameter is not filtered out
image

Expected result:

dclid=1 parameter is filtered out

image

Reproduces how often:

Easily reproduced

Desktop Brave version:

Reproducible on

Brave 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Linux

Not reproducible on

Brave 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS
Brave 1.14.84 Chromium: 85.0.4183.121 (Oficjalna wersja) (64-bitowa)
Wersja a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @fmarier @rebron @bsclifton

@btlechowski btlechowski added privacy/tracking Preventing sites from tracking users across the web QA/Yes QA/Test-Plan-Specified regression OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Sep 30, 2020
@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.16.46

@fmarier
Copy link
Member

fmarier commented Sep 30, 2020

Thanks @GeetaSarvadnya and @btlechowski for catching this oversight in the tests I added. This is in fact a logic error which we will need to fix on Beta too.

@fmarier fmarier changed the title Tracking query string parameter filtering does not work Direct navigations are extempted from the query string filter Sep 30, 2020
@fmarier fmarier changed the title Direct navigations are extempted from the query string filter Direct navigations are wrongly exempted from the query string filter Sep 30, 2020
fmarier added a commit to brave/brave-core that referenced this issue Oct 2, 2020
@fmarier fmarier added this to the 1.17.x - Nightly milestone Oct 2, 2020
@fmarier
Copy link
Member

fmarier commented Oct 5, 2020

As mentioned in #11930 (comment), in addition to copy/pasting the URL in the URL bar, choosing "Open the link in a private window" also lead to the query string not getting filtered.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 9, 2020

Verified passed with

Brave	1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (x86_64)
Revision	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6741

Verified STR from description including all listed parameters.


Verification passed on


Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)


Verified test plan from brave/brave-core#6741

Verified STR from description including all listed parameters.


Verification passed on

Brave 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6741

Verified STR from description including all listed parameters.

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.16.69 x64 build


Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants