-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove URL/ID identifiers from reward logs for various publishers - follow up to #11795 #11992
Comments
@LaurenWags this are not rewards logs, this is something that chromium and other services will print out. We can close this one as this will not go in rewards logs |
@kjozwiak you ok with this since you had logged the original issue? |
@LaurenWags does this happen when brave is launched without any special arguments? |
@diracdeltas I do not see those log messages when I launch via terminal with the following:
But I can reproduce at least one of the YouTube messages when I use the logging parameters only (no specific rewards ones):
The other YouTube message from the description isn't showing with only the two args above however I can dig in further if you'd like, let me know what I can do to help.
|
you see this because you enabled chromium logging |
@NejcZdovc yes, understood. I only got the 1 message though and there are 3 that were still occurring. I'd imagine if I started turning on the other flags one by one I might get the other 2 (maybe not though, since things have changed with Greaselion since this issue was logged). Not sure if that's needed information. |
just to clarify, these are logs that appear in the terminal? (as opposed to rewards-internals logs) |
@LaurenWags Old, but @diracdeltas is correct in her understanding, right?
If @diracdeltas thinks it's unproblematic in that case (and it is indeed the case), then we can close this out. |
@Miyayes iirc yes, from the terminal. |
@diracdeltas given LaurenWags's confirmation, is this still an issue, or should we close this out as |
Description
Per #11795 some publisher info can still be seen in logs (launched via terminal as noted below, not available in the browser).
Visiting YT channels/publishers will produce the following logs which includes the channel ID as per the following:
Visiting Twitter pages/users will produce the following logs which includes the full URL of the page being visited as per the following:
Steps to Reproduce
Launch Brave using the following switches via a terminal/CLI:
Actual result:
Logs provided above re: results. Certain websites are still logging URLs/ID's via the logs.
Expected result:
Any identifying URLs/information should be removed from being dumped into the terminal/logs.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @kjozwiak @rebron @NejcZdovc
The text was updated successfully, but these errors were encountered: