remove URL/ID identifiers from reward logs for various publishers - follow up to #11343

[kjozwiak]

Description

As per #11343, we've removed URLs being dumped into rewards logs. However, there's some instances/cases where URLs or ID identifiers are still appearing in the logs. Some examples:

Visiting YT channels/publishers will produce the following logs which includes the channel ID as per the following:

[53068:775:0920/221943.994651:INFO:CONSOLE(0)] "Refused to display 'https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Fwww.youtube.com%2Fsignin%3Faction_handle_signin%3Dtrue%26app%3Ddesktop%26feature%3Dpassive%26hl%3Den%26next%3D%252Fsignin_passive&hl=en&passive=true&service=youtube&uilel=3' in a frame because it set 'X-Frame-Options' to 'deny'.", source: https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A/videos (0)

[53068:775:0920/221947.186010:INFO:CONSOLE(0)] "The resource https://i.ytimg.com/generate_204 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.", source: https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A/videos (0)

Visiting Twitter pages/users will produce the following logs which includes the full URL of the page being visited as per the following:

[53068:775:0920/222639.128671:VERBOSE1:rewards_service_impl.cc(1811)] Already fetching favicon: https://twitter.com/bravelaurenwags/profile_image?size=original
[53068:775:0920/222639.580927:INFO:CONSOLE(0)] "ResizeObserver loop limit exceeded", source: https://twitter.com/bravelaurenwags (0)

Visiting Vimeo pages will produce the following logs which includes the channels ID as per the following:

[53068:775:0920/223055.942062:VERBOSE1:database_publisher_info.cc(182)] Filter is empty
[53068:775:0920/223055.942536:INFO:vimeo.cc(645)] User id is missing for: vimeo_456161998
[53068:775:0920/223056.075582:VERBOSE1:database_publisher_info.cc(182)] Filter is empty
[53068:775:0920/223056.075894:INFO:vimeo.cc(645)] User id is missing for: vimeo_456161998
[53068:775:0920/223056.196992:VERBOSE1:database_publisher_info.cc(182)] Filter is empty
[53068:775:0920/223056.197595:INFO:vimeo.cc(645)] User id is missing for: vimeo_456161998

BTW, the above might not be high priority but I'll get the @brave/sec-team decide 👍

Steps to Reproduce

Launch Brave using the following switches via a terminal/CLI:

 --args --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6

1. Visit any TY channel and you'll notice the URL being logged with the channel's ID
2. Visit Twitter and you'll notice the URL being logged with the full URL
3. Visit Vimeo and you'll notice the channel ID is being logged

Actual result:

Logs provided above re: results. Certain websites are still logging URLs/ID's via the logs.

Expected result:

Any identifying URLs/information should be removed from being dumped into the terminal/logs.

Reproduces how often:

100% reproducible using the above STR.

Desktop Brave version:

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes, reproducible
• Can you reproduce this issue with the beta channel? Yes, reproducible
• Can you reproduce this issue with the nightly channel? Yes, reproducible

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? Yes, won't get the logs if rewards is disabled
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @LaurenWags @NejcZdovc

[diracdeltas]

@kjozwiak to clarify, do you only see these logs if you have are running with non-default command line options?

[LaurenWags]

Verified passed with

Brave | 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (x86_64)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from the issue (launched with --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --rewards=staging=true)

Confirmed visiting a vimeo page (ex. vimeo.com/bravelaurenwags) and playing a video does not show any channel info in the logs.

Partial fix for Twitter logging info, the following was still observed when visiting twitter.com/bravelaurenwags:

[821:775:1005/092550.669785:INFO:CONSOLE(0)] "ResizeObserver loop limit exceeded", source: https://twitter.com/bravelaurenwags (0)

YouTube info in logs was still observed as it was noted in the issue description:

[821:775:1005/092319.810726:INFO:CONSOLE(0)] "Refused to display 'https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Fwww.youtube.com%2Fsignin%3Faction_handle_signin%3Dtrue%26app%3Ddesktop%26feature%3Dpassive%26hl%3Den%26next%3D%252Fsignin_passive&hl=en&passive=true&service=youtube&uilel=3' in a frame because it set 'X-Frame-Options' to 'deny'.", source: https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A/videos (0)

[821:775:1005/092323.184051:INFO:CONSOLE(0)] "The resource https://i.ytimg.com/generate_204 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.", source: https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A/videos (0)

Logged follow up issue for remaining Twitter & YouTube logs - #11992

---

Verification passed on

Brave	1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (64-bit)
Revision	ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS	Ubuntu 18.04 LTS

Verified STR from the description

Verified visiting a vimeo page and playing a video does not show any channel info in the rewards logs.
Verified visiting a creator's Twitter page does not show any channel info in the rewards logs.
Verified visiting a YouTube page and playing a video does not show any channel info in the rewards logs.

---

Verification passed on

Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified visiting a vimeo page and playing a video does not show any channel info in the rewards logs
Verified visiting a creator's Twitter page does not show any channel info in the rewards logs
Verified visiting a YouTube page and playing a video does not show any channel info in the rewards logs