remove verified publisher URL from logs #11343

LaurenWags · 2020-08-20T15:14:43Z

Description

Found while testing #10832

If you visit a verified publisher, that URL is shown in rewards logs in certain cases. Example below, although there could be others.

Steps to Reproduce

Clean profile, enable Rewards
Navigate to a verified publisher
Look at logs (brave://rewards-internals or terminal)

Actual result:

See publisher URL in logs like below, looks like it's attempting to get banner info, etc:

[Aug 19, 2020, 11:04:27.4 AM:INFO:database_server_publisher_banner.cc(139)] Server publisher banner not found
[Aug 19, 2020, 11:04:27.4 AM:INFO:ledger_impl.cc(1232)] Server publisher info  is expired for laurenwags.github.io
[Aug 19, 2020, 11:04:27.4 AM:INFO:server_publisher_fetcher.cc(165)] Fetching server publisher info for laurenwags.github.io
[Aug 19, 2020, 11:04:27.4 AM:VERBOSE5:ledger_impl.cc(475)] 
[ REQUEST ]
> URL: https://pcdn.bravesoftware.com/publishers/prefixes/c04d
> Method: UrlMethod::GET
[Aug 19, 2020, 11:04:27.4 AM:INFO:database_server_publisher_banner.cc(139)] Server publisher banner not found
[Aug 19, 2020, 11:04:27.4 AM:INFO:ledger_impl.cc(1232)] Server publisher info  is expired for laurenwags.github.io
[Aug 19, 2020, 11:04:27.4 AM:INFO:server_publisher_fetcher.cc(161)] Fetch already in progress for publisher laurenwags.github.io
[Aug 19, 2020, 11:04:27.5 AM:VERBOSE2:ads_impl.cc(450)] Tab id 3 is visible
[Aug 19, 2020, 11:04:27.5 AM:VERBOSE3:ads_impl.cc(460)] Event log: {"data":{"type":"focus","timestamp":"0 hours, 0 minutes, 0 seconds at 11:04 AM","tabId":3}}
[Aug 19, 2020, 11:04:27.5 AM:INFO:database_server_publisher_banner.cc(139)] Server publisher banner not found
[Aug 19, 2020, 11:04:27.5 AM:INFO:ledger_impl.cc(1232)] Server publisher info  is expired for laurenwags.github.io
[Aug 19, 2020, 11:04:27.5 AM:INFO:server_publisher_fetcher.cc(161)] Fetch already in progress for publisher laurenwags.github.io

Expected result:

no URL information in logs

Reproduces how often:

easily

Desktop Brave version:

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Android Device details:

Install type (ARM, x86):
Device type (Phone, Tablet, Phablet):
Android version:

Version/Channel Information:

Can you reproduce this issue with the current release? yes, 1.12.x
Can you reproduce this issue with the beta channel? yes, 1.13.x (note - logs are removed/turned off in 1.13.78 and above)
Can you reproduce this issue with the nightly channel? yes, 1.14.x (note, logs are still off in this version)

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc

The text was updated successfully, but these errors were encountered:

LaurenWags · 2020-08-20T15:15:40Z

Note - added OS/Android tag but if this is not applicable please remove. cc @srirambv

Resolves brave/brave-browser#11343

GeetaSarvadnya · 2020-09-18T15:14:12Z

Verification passed on


Brave | 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified STR from the description
Reproduced the issue in 1.14.x

[13892:980:0918/193016.961:VERBOSE1:database_server_publisher_banner.cc(141)] Server publisher banner not found
[13892:980:0918/193016.962:VERBOSE1:publisher.cc(780)] Server publisher info  is expired for laurenwags.github.io
[13892:980:0918/193016.964:VERBOSE5:ledger_impl.cc(124)]
[ REQUEST ]
> URL: https://pcdn.bravesoftware.com/publishers/prefixes/c04d
> Method: UrlMethod::GET
[13892:980:0918/193016.996:VERBOSE1:database_server_publisher_banner.cc(141)] Server publisher banner not found
[13892:980:0918/193016.998:VERBOSE1:publisher.cc(780)] Server publisher info  is expired for laurenwags.github.io
[13892:980:0918/193016.998:VERBOSE1:server_publisher_fetcher.cc(56)] Fetch already in progress
[13892:980:0918/193017.014:VERBOSE2:ads_impl.cc(450)] Tab id 4 is visible
[13892:980:0918/193017.016:VERBOSE1:database_server_publisher_banner.cc(141)] Server publisher banner not found
[13892:980:0918/193017.017:VERBOSE1:publisher.cc(780)] Server publisher info  is expired for laurenwags.github.io
[13892:980:0918/193017.025:VERBOSE1:server_publisher_fetcher.cc(56)] Fetch already in progress

Verified that the issue is not reproducible in 1.15.x, publisher URL is not shown in the logs


[27892:7512:0918/195059.424:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[27892:7512:0918/195059.426:VERBOSE5:ledger_impl.cc(128)]
[ REQUEST ]
> URL: https://pcdn.bravesoftware.com/publishers/prefixes/c04d
> Method: UrlMethod::GET
[27892:7512:0918/195059.465:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[27892:7512:0918/195059.466:VERBOSE1:server_publisher_fetcher.cc(58)] Fetch already in progress
[27892:7512:0918/195059.482:VERBOSE2:ads_impl.cc(450)] Tab id 4 is visible
[27892:7512:0918/195059.484:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Verified the STR/Cases outlined via remove verified publisher URL from logs #11343 (comment)
Visited the following websites on staging and ensured it wasn't being displayed in the logs
- https://laurenwags.github.io (verified publisher on staging)
- https://www.vimeo.com/bravelaurenwags (verified publisher on staging)
- https://www.github.com/laurenwags (verified publisher on staging)
- https://kjozwiakstaging.github.io (verified publisher on staging)
- https://www.twitch.tv/laurenwags (verified publisher on staging)
- http://reddit.com/u/beachbum0407 (verified publisher on staging)
- https://twitter.com/bravelaurenwags (verified publisher on staging)
- https://www.chess.com/ (unverified publisher on staging)
- https://vimeo.com/456161998 (unverified publisher on staging)
- https://github.com/kjozwiak (unverified publisher on staging)
- https://www.twitch.tv/pokimane (unverified publisher on staging)
- https://www.reddit.com/user/yonandalie (unverified publisher on staging)

Verification passed on

Brave	1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	Ubuntu 18.04 LTS

Verified the STR/Cases outlined via remove verified publisher URL from logs #11343 (comment)
Visited the following websites on staging and ensured it wasn't being displayed in the logs
- https://laurenwags.github.io (verified publisher on staging)
- https://www.vimeo.com/bravelaurenwags (verified publisher on staging)
- https://www.github.com/laurenwags (verified publisher on staging)
- https://kjozwiakstaging.github.io (verified publisher on staging)
- https://www.twitch.tv/laurenwags (verified publisher on staging)
- http://reddit.com/u/beachbum0407 (verified publisher on staging)
- https://twitter.com/bravelaurenwags (verified publisher on staging)
- https://www.chess.com/ (unverified publisher on staging)
- https://vimeo.com/456161998 (unverified publisher on staging)
- https://github.com/kjozwiak (unverified publisher on staging)
- https://www.twitch.tv/pokimane (unverified publisher on staging)
- https://www.reddit.com/user/yonandalie (unverified publisher on staging)

kjozwiak · 2020-09-21T02:36:39Z

@NejcZdovc just double checking, seeing the following being listed in the logs when visiting the following websites/publishers. I don't think any of the below are blockers but should we be remove these as well? Create a follow issue to address the below?

Visiting YT channels displays the entire link of the channel as per the following:

[53068:775:0920/221943.994651:INFO:CONSOLE(0)] "Refused to display 'https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Fwww.youtube.com%2Fsignin%3Faction_handle_signin%3Dtrue%26app%3Ddesktop%26feature%3Dpassive%26hl%3Den%26next%3D%252Fsignin_passive&hl=en&passive=true&service=youtube&uilel=3' in a frame because it set 'X-Frame-Options' to 'deny'.", source: https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A/videos (0)

[53068:775:0920/221947.186010:INFO:CONSOLE(0)] "The resource https://i.ytimg.com/generate_204 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.", source: https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A/videos (0)

Visiting Twitter publishers/users displays the following in the logs:

[53068:775:0920/222639.128671:VERBOSE1:rewards_service_impl.cc(1811)] Already fetching favicon: https://twitter.com/bravelaurenwags/profile_image?size=original
[53068:775:0920/222639.580927:INFO:CONSOLE(0)] "ResizeObserver loop limit exceeded", source: https://twitter.com/bravelaurenwags (0)

Visiting some Vimeo videos will display the channel ID in the logs. Example: visiting https://vimeo.com/456161998:

[53068:775:0920/223055.942062:VERBOSE1:database_publisher_info.cc(182)] Filter is empty
[53068:775:0920/223055.942536:INFO:vimeo.cc(645)] User id is missing for: vimeo_456161998
[53068:775:0920/223056.075582:VERBOSE1:database_publisher_info.cc(182)] Filter is empty
[53068:775:0920/223056.075894:INFO:vimeo.cc(645)] User id is missing for: vimeo_456161998
[53068:775:0920/223056.196992:VERBOSE1:database_publisher_info.cc(182)] Filter is empty
[53068:775:0920/223056.197595:INFO:vimeo.cc(645)] User id is missing for: vimeo_456161998

kjozwiak · 2020-09-21T20:42:46Z

Talked to @NejcZdovc and created #11795 re: #11343 (comment).

srirambv · 2020-09-22T10:35:00Z

Verification passed on OnePlus 6T with Android 10 running 1.15.54 x64 beta build

Reproduced issue on release build 1.14.83

2020-09-22 11:15:13.228 9414-9414/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(141)] Server publisher banner not found
2020-09-22 11:15:13.231 9414-9414/? V/chromium: [VERBOSE1:publisher.cc(780)] Server publisher info  is expired for wikipedia.org
2020-09-22 11:15:13.231 9414-9414/? V/chromium: [VERBOSE5:ledger_impl.cc(124)] 
    [ REQUEST ]
    > URL: https://pcdn.brave.com/publishers/prefixes/da6b
    > Method: UrlMethod::GET
2020-09-22 11:15:13.355 9414-9414/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://pcdn.brave.com/publishers/prefixes/da6b
    > Result: Success
    > HTTP Code: 200
    > Body: 
2020-09-22 11:15:13.356 9414-9414/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(42)] Empty publisher banner data, skipping insert
2020-09-22 11:15:13.389 9414-9414/? V/chromium: [VERBOSE1:publisher.cc(502)] Publisher list is empty
2020-09-22 11:15:17.242 9414-9414/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(141)] Server publisher banner not found

Verified no publisher URL is shown in logs on beta channel

2020-09-22 11:22:39.262 10377-10377/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
2020-09-22 11:22:39.263 10377-10377/? V/chromium: [VERBOSE5:ledger_impl.cc(128)] 
    [ REQUEST ]
    > URL: https://pcdn.bravesoftware.com/publishers/prefixes/6a92
    > Method: UrlMethod::GET
2020-09-22 11:22:39.682 10377-10377/? V/chromium: [VERBOSE2:ads_impl.cc(450)] Tab id 4 is visible
2020-09-22 11:22:39.262 10377-10377/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found

Verification passed on Samsung Tab A with Android 10 running 1.15.54 x64 beta build

Reproduced issue on release build 1.14.83

2020-09-22 11:31:19.118 8968-8968/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(141)] Server publisher banner not found
2020-09-22 11:31:19.119 8968-8968/? V/chromium: [VERBOSE1:publisher.cc(780)] Server publisher info  is expired for neowin.net
2020-09-22 11:31:19.119 8968-8968/? V/chromium: [VERBOSE5:ledger_impl.cc(124)] 
    [ REQUEST ]
    > URL: https://pcdn.brave.com/publishers/prefixes/06c5
    > Method: UrlMethod::GET
2020-09-22 11:31:19.820 8968-8968/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://pcdn.brave.com/publishers/prefixes/06c5
    > Result: Success
    > HTTP Code: 200
    > Body: 
2020-09-22 11:31:23.499 8968-8968/? V/chromium: [VERBOSE1:ads_impl.cc(1266)] Visited URL does not match the last shown ad notification

Verified no publisher URL is shown in logs on beta channel

2020-09-22 11:33:58.166 10385-10385/? V/chromium: [VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
2020-09-22 11:33:58.168 10385-10385/? V/chromium: [VERBOSE5:ledger_impl.cc(128)] 
    [ REQUEST ]
    > URL: https://pcdn.brave.com/publishers/prefixes/06c5
    > Method: UrlMethod::GET
2020-09-22 11:33:58.169 2848-9568/? D/ActivityManager_KPM: Killed Process Scenario:70 , App PID:10855 , App Name:com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:8 , App ADJ:0 , App AdjType:exec-service , Current CCH-ACT Count:0 , Proc State:11
2020-09-22 11:33:59.197 10385-10385/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://pcdn.brave.com/publishers/prefixes/06c5
    > Result: Success
    > HTTP Code: 200
    > Body: 
2020-09-22 11:33:59.263 10385-10385/? V/chromium: [VERBOSE1:publisher.cc(504)] Publisher list is empty

LaurenWags added feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 20, 2020

LaurenWags mentioned this issue Aug 20, 2020

[Desktop] Do not log classified page url in locally persisted diagnostic log for Brave Ads #10832

Closed

NejcZdovc self-assigned this Aug 20, 2020

NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 20, 2020

Removes publisher key from logs

2c34a6d

Resolves brave/brave-browser#11343

NejcZdovc mentioned this issue Aug 20, 2020

Removes publisher key from logs brave/brave-core#6466

Merged

32 tasks

NejcZdovc closed this as completed in brave/brave-core#6466 Aug 21, 2020

NejcZdovc added this to the 1.15.x - Nightly milestone Aug 21, 2020

NejcZdovc added the release-notes/exclude label Aug 21, 2020

GeetaSarvadnya added the QA Pass-Win64 label Sep 18, 2020

kjozwiak added the QA Pass-macOS label Sep 21, 2020

kjozwiak mentioned this issue Sep 21, 2020

remove URL/ID identifiers from reward logs for various publishers - follow up to #11343 #11795

Closed

btlechowski added the QA Pass-Linux label Sep 21, 2020

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels Sep 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove verified publisher URL from logs #11343

remove verified publisher URL from logs #11343

LaurenWags commented Aug 20, 2020

LaurenWags commented Aug 20, 2020

GeetaSarvadnya commented Sep 18, 2020 •

edited by btlechowski

Loading

kjozwiak commented Sep 21, 2020 •

edited

Loading

kjozwiak commented Sep 21, 2020

srirambv commented Sep 22, 2020

remove verified publisher URL from logs #11343

remove verified publisher URL from logs #11343

Comments

LaurenWags commented Aug 20, 2020

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

LaurenWags commented Aug 20, 2020

GeetaSarvadnya commented Sep 18, 2020 • edited by btlechowski Loading

kjozwiak commented Sep 21, 2020 • edited Loading

kjozwiak commented Sep 21, 2020

srirambv commented Sep 22, 2020

GeetaSarvadnya commented Sep 18, 2020 •

edited by btlechowski

Loading

kjozwiak commented Sep 21, 2020 •

edited

Loading