unable to tip from panel when disabling content-level tips

[LaurenWags]

Description

Found while testing #11997

If you disable content-level tips (ex. for Twitter), you can no longer tip that publisher type/platform from the panel.

Steps to Reproduce

Scenario 1: clean profile

1. Using 1.17.x, enable rewards
2. Disable Twitter content-level tips (brave://rewards > Tips panel > open settings > uncheck Twitter)
3. Navigate to a site like twitter.com/emerick
4. Note in-line tip button is not displayed (this is expected)
5. Open panel

Scenario 2: upgraded profile

1. Using 1.16.x, enable rewards
2. Disable Twitter content-level tips (brave://rewards > Tips panel > open settings > uncheck Twitter)
3. Navigate to a site like twitter.com/emerick
4. Note in-line tip button is not displayed (this is expected)
5. Open panel, publisher info is displayed, you are able to tip
6. Close and upgrade to 1.17.x
7. Go to same site and open panel

Actual result:

Unable to tip from panel:

Expected result:

When content-level tips are disabled you should still be able to tip from the panel as you can in 1.16.x:

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.17.25 Chromium: 86.0.4240.75 (Official Build) nightly (x86_64)
Revision	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? no
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @emerick

[NejcZdovc]

@emerick I see two options:

1. we will need to use this variable dynamically and not set it as a pre condition, but use it as variable in the script, so that we can dynamically inject things in based on this condition

2. split twitter in two scripts. One would be twitter-base (where we would have everything for handling publisher and panel, no pre-condition, needs to run all the time) and second one twitter-inline which would handle inline tipping (this one can then have pre-condition)

cc @petemill @pilgrim-brave

[petemill]

Injecting 2 scripts seems reasonable (as additive or exclusive depending on if there's overlap in logic, both should be easy with webpack). There would still be a precondition on the first, right? At least for rewards enabled in general.

[LaurenWags]

Reproduces when disabling content-level tips for Reddit as well:

Brave	1.17.50 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

[LaurenWags]

Requires an uplift, labeling as QA/Blocked until that is completed.

[LaurenWags]

Verified passed with

Brave	1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision	37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS	macOS Version 10.14.6 (Build 18G6032)

Verified STR from description.
Verified test plan from brave/brave-core#6889.

Reddit

Unchecked content level tips for Reddit:

Confirmed no content level tip icon on user page or subreddit pages:

Confirmed still able to tip from panel with content level tip icon disabled:

Confirmed setting retained on relaunch.
Confirmed visiting the pages after relaunch still does not show content level tip icon.
Confirmed re-enabling content level tips (and refreshing page if open) shows the in-line tip icon again.

Twitter

Unchecked content level tips for Twitter:

Confirmed no content level tip icon on Twitter:

Confirmed still able to tip from panel with content level tip icon disabled:

Confirmed setting retained on relaunch.
Confirmed visiting the page again still does not show content level tip icon.
Confirmed re-enabling content level tips (and refreshing page if open) shows the in-line tip icon again.

GitHub

Unchecked content level tips for GitHub:

Confirmed no content level tip icon on GitHub:

Confirmed still able to tip from panel with content level tip icon disabled (only tipped from the panel on 2 of the above pages, not all):

Confirmed setting retained on relaunch.
Confirmed visiting the page again still does not show content level tip icon.
Confirmed re-enabling content level tips (and refreshing page if open) shows the in-line tip icon again.

Confirmed for upgrade profiles also. Set up 1.16.72 profile with content level tips disabled for the 3 types. Upgraded to 1.17.x Visited Reddit, Twitter, and GH pages. Confirmed setting retained. Confirmed visiting pages did not show in-line tip button.

---

Verification passed on

Brave	1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified STR from description.
Verified test plan from brave/brave-core#6889.

Reddit

Unchecked content level tips for Reddit:

Confirmed no content level tip icon on user page or subreddit pages:

Confirmed still able to tip from panel with content level tip icon disabled:

Confirmed setting retained on relaunch.
Confirmed visiting the pages after relaunch still does not show content level tip icon.
Confirmed re-enabling content level tips (and refreshing page if open) shows the in-line tip icon again.

Twitter

Unchecked content level tips for Twitter:

Confirmed no content level tip icon on Twitter:

Confirmed still able to tip from panel with content level tip icon disabled:

Confirmed setting retained on relaunch.
Confirmed visiting the page again still does not show content level tip icon.
Confirmed re-enabling content level tips (and refreshing page if open) shows the in-line tip icon again.

GitHub

Unchecked content level tips for GitHub:

Confirmed no content level tip icon on GitHub:

Confirmed still able to tip from panel with content level tip icon disabled

Confirmed setting retained on relaunch.
Confirmed visiting the page again still does not show content level tip icon.
Confirmed re-enabling content level tips (and refreshing page if open) shows the in-line tip icon again.

Confirmed for upgrade profiles also. Set up 1.16.72 profile with content level tips disabled for the 3 types. Upgraded to 1.17.x Visited Reddit, Twitter, and GH pages. Confirmed setting retained. Confirmed visiting pages did not show in-line tip button.