[Desktop] Use Greaselion for Reddit publishers

[NejcZdovc]

we should switch to GL for Reddit so that we can have faster turn around rate when something breaks.

[LaurenWags]

Notes for testing

Prior to testing, I discussed with Emerick the "Verify that tip icon is inserted in expected locations" statement from the PR. This is the information he provided:

• for old reddit, we insert the tip icon for comments, replies and initial posts.
• for new reddit, we insert it for initial posts, replies from the user, and promoted posts.
• in general, we try to insert it whenever the little "toolbar" is there for a post/reply

Verification in progress with:

Brave	1.17.45 Chromium: 86.0.4240.99 (Official Build) dev (x86_64)
Revision	002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS	macOS Version 10.14.6 (Build 18G3020)

General

Using build above:

• Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.32

• Confirmed visiting non-verified publishers showed the generic Reddit favicon in panel. Visited each of the below using a clean profile (staging env):
  • reddit.com/user/cryptojennie
  • old.reddit.com/user/brave_w0ts0n showed incorrect favicon, logged [Desktop] incorrect favicon for old reddit on panel #12301

Brave	1.17.48 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

History

Using build above:
Verified test plan from brave/brave-core#6824

Panel did not always update correctly, logged #12302

Brave	1.17.50 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

Post on New Reddit

Using build above:
Verified test plan from brave/brave-core#6824

Confirmed expected publisher info displayed in panel and tipping banner:

Confirmed tipping a non-verified publisher goes to pending list:

Confirmed able to see tip button in the following areas when content-level tips for Reddit are enabled:

Initial posts (both logged in and not logged in):

Replies from the user:

On Promoted Posts:

Confirmed able to tip verified reddit user via panel and in-line tip button:

Reproduced #12090 - when content-level tips are disabled cannot tip Reddit user via the panel.

Encountered and logged #12345 for missing inline tip button in certain cases on new reddit.

Brave	1.17.52 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

Post on Old Reddit

Using build above:
Verified test plan from brave/brave-core#6824

Confirmed expected publisher info displayed in panel and tipping banner. Note, encountered #12301 while testing for incorrect favicon:

Confirmed tipping a non-verified publisher goes to pending list:

Confirmed able to see tip button in the following areas when content-level tips for Reddit are enabled:

• Initial posts (both logged in and not logged in)
• Replies
• Comments

Confirmed able to tip verified reddit user via panel and in-line tip button:

Reproduced #12090 - when content-level tips are disabled cannot tip Reddit user via the panel.

Promoted Post on New Reddit Feed

Using build above:
Verified test plan from brave/brave-core#6824 using staging env

Encountered #12241 while testing

Confirmed when on my feed on new reddit a promoted post showed the in-line tip button:

Confirmed expected panel info (reddit.com) showed both before and after clicking in-line tip button:

Confirmed tipping to non-verified publisher went to pending list:

Unable to check verified publisher icon and tipping as no promoted posts were verified publishers.

Brave	1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

Excluded URL

Using build above:
Verified test plan from brave/brave-core#6824

Confirmed reddit.com displays in the panel for excluded URL:

Spot checked other excluded URLs:

Activity

Per discussion with Emerick, users like "CryptoJennie on Reddit" will not be added to AC until #12107 is addressed. Note - prior to using Greaselion for Reddit tipping, Reddit creators were not added to AC either so this is not new.

However, instead of verifying exact test plan from brave/brave-core#6824, I confirmed that visiting https://www.reddit.com/user/CryptoJennie for at least minimum time results in reddit.com being added to AC table. This is sufficient for now per my discussions:

Also checked https://old.reddit.com/user/CryptoJennie on a clean profile and confirmed only reddit.com added to AC list as expected.

Tab Activation

Verified test plan from brave/brave-core#6824

Confirmed opening reddit URLs in various tabs showed the expected information in panel. Used a mix of user pages (ex. reddit.com/user/alex_the_brave), sub reddits (https://www.reddit.com/r/brave_browser/), and posts (https://www.reddit.com/r/AnimalsBeingJerks/comments/jizo3f/she_knows_exactly_what_she_is_doing/)

Encountered #12357, #12302

Tipping non-Reddit publishers

Verified test plan from brave/brave-core#6824

Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, YouTube, Twitter. Vimeo panel is currently broken (#11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.

Confirmed able to do a 1time tip and set up recurring tip for:

Website:

GitHub (uses Greaselion in 1.17.x and above:

Twitch:

YouTube (uses Greaselion in 1.16.x and above):

Twitter (uses Greaselion in 1.17.x and above):

Other Various Tests - Settings

• Confirmed content level tips checkbox for Reddit
• Confirmed able to toggle this on/off
• Encountered unable to tip from panel when disabling content-level tips #12090 while testing this

Other Various Tests - panel and banner messaging

• Confirm non-verified Reddit publishers show specific messaging on panel/banners (staging env)

• Confirm verified, non-KYC'd Reddit publishers show specific messaging on panel/banners (staging env)
  • Logged [Desktop] tipping banners do not show messaging for creators not being able to accept tips #12362 for missing messaging on tipping banners

• Confirm verified, KYC'd Reddit publishers do not show any messaging on panel/banners (staging env)

Upgrade

Using 1.16.68 (current 1.16.x release version), set up the following data:

• Have a few 1 time tips to verified publishers completed (some to Reddit publishers, some other publisher types also)
• Have a few pending 1 time tips to non-verified Reddit publishers
• Have a few recurring tips to verified publishers configured (some to Reddit publishers, some other publisher types also)
• Have AC list populated with a mix of verified and non-verified sites, a mix of publisher types

Upgrade to 1.17.x (on Dev channel, need to rename profile) with Graselion Reddit tipping

• Confirm all data is preserved as expected on brave://rewards.
• Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable)
• For an existing recurring tip, confirm you are able to adjust the recurring tip amount for Reddit publisher from the panel
• For an existing recurring tip, confirm you are able to delete a recurring tip for Reddit publisher
• Confirm able to do a new 1 time tip to Reddit publisher

---

Verification passed on

Brave	1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

General

Using build above:

• Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.32

• Confirmed visiting non-verified publishers showed the generic Reddit favicon in panel. Visited each of the below using a clean profile (staging env):
  • reddit.com/user/cryptojennie
    
  • old.reddit.com/user/brave_w0ts0n
    

History

Verified test plan from brave/brave-core#6824
Did not reproduce #12302

Post on New Reddit

Verified test plan from brave/brave-core#6824

Confirmed expected publisher info displayed in panel and tipping banner:

Confirmed tipping a non-verified publisher goes to pending list:

Confirmed able to see tip button in the following areas when content-level tips for Reddit are enabled:

Initial posts:

Replies from the user:

On Promoted Posts:

Confirmed able to tip verified reddit user via panel and in-line tip button:

Encountered #12345 for missing inline tip button in certain cases on new reddit.

Post on Old Reddit

Verified test plan from brave/brave-core#6824

Confirmed expected publisher info displayed in panel and tipping banner. Note, encountered #12301 while testing for incorrect favicon:

Confirmed tipping a non-verified publisher goes to pending list:

Confirmed able to see tip button in the following areas when content-level tips for Reddit are enabled:

• Initial posts
• Replies
• Comments

Confirmed able to tip verified reddit user via panel and in-line tip button:

Promoted post:

Brave	1.17.59 Chromium: 86.0.4240.183 (Official Build) dev (64-bit)
Revision	0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS	Ubuntu 18.04 LTS

Promoted Post on New Reddit Feed

Verified test plan from https://github.com/brave/brave-core/pull/6824 using staging env

Encountered #12241 while testing

Confirmed when on my feed on new reddit a promoted post showed the in-line tip button:

Confirmed expected panel info (reddit.com) showed both before and after clicking in-line tip button.
Unable to check verified publisher icon and tipping as no promoted posts were verified publishers.

Excluded URL

Verified test plan from brave/brave-core#6824

Confirmed reddit.com displays in the panel for excluded URL:

Spot checked other excluded URLs:

Activity

Unable to test due to #12107
Ensured that reddit.com is added instead to the a-c table

Tab Activation

Verified test plan from brave/brave-core#6824

Confirmed opening reddit URLs in various tabs showed the expected information in panel. Used a mix of user pages (ex. reddit.com/user/alex_the_brave), sub reddits (https://www.reddit.com/r/brave_browser/), and posts (https://www.reddit.com/r/AnimalsBeingJerks/comments/jizo3f/she_knows_exactly_what_she_is_doing/)

Encountered #12357, #12302
Logged

Tipping non-Reddit publishers

Verified test plan from brave/brave-core#6824

Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, YouTube, Twitter. Vimeo panel is currently broken (#11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.

Confirmed able to do a 1time tip and set up recurring tip for:

Regular site:

YouTube:

GitHub:

Twitch:

Twitter:

Vimeo(broken):

Recurring and 1 time tips:

Other Various Tests - Settings

• Confirmed content level tips checkbox for Reddit
• Confirmed able to toggle this on/off
• Encountered unable to tip from panel when disabling content-level tips #12090

Upgrade

Using 1.16.68 (current 1.16.x release version), set up the following data:

• Have a few 1 time tips to verified publishers completed (some to Reddit publishers, some other publisher types also)
• Have a few pending 1 time tips to non-verified Reddit publishers
• Have a few recurring tips to verified publishers configured (some to Reddit publishers, some other publisher types also)
• Have AC list populated with a mix of verified and non-verified sites, a mix of publisher types

Upgrade to 1.17.x (on Dev channel, need to rename profile) with Graselion Reddit tipping

• Confirm all data is preserved as expected on brave://rewards.
• Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable)
• For an existing recurring tip, confirm you are able to adjust the recurring tip amount for Reddit publisher from the panel
• For an existing recurring tip, confirm you are able to delete a recurring tip for Reddit publisher
• Confirm able to do a new 1 time tip to Reddit publisher

---

Verification passed on

Brave	1.17.69 Chromium: 87.0.4280.60 (Official Build) (64-bit)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

After internal discussion the test plan on Windows was reduced

General

Using build above:

• Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.32

• Confirmed visiting non-verified publishers showed the generic Reddit favicon in panel. Visited each of the below using a clean profile (staging env):
  • reddit.com/user/cryptojennie
    
  • old.reddit.com/user/brave_w0ts0n
    

Post on New Reddit

Verified test plan from brave/brave-core#6824

Confirmed expected publisher info displayed in panel and tipping banner:

Confirmed tipping a non-verified publisher goes to pending list:

Initial posts:

Replies from the user:

Confirmed able to tip verified reddit user via panel and in-line tip button:

Encountered #12345 for missing inline tip button in certain cases on new reddit.

Post on Old Reddit

Verified test plan from brave/brave-core#6824

Confirmed expected publisher info displayed in panel and tipping banner. Note, encountered #12301 while testing for incorrect favicon:

Confirmed tipping a non-verified publisher goes to pending list:

Confirmed able to see tip button in the following areas when content-level tips for Reddit are enabled:

• Initial posts
• Replies
• Comments

Confirmed able to tip verified reddit user via panel and in-line tip button:

---