reddit tipping banner taking ~5-8s to appear/display when using inline tipping under reddit

[kjozwiak]

Description

When clicking on the inline BAT icon on reddit, it takes the tipping banner anywhere between 5-8s to appear. Because of this delay, some users might think the UI isn't responsive/broken or click on the BAT several times which leads to multiple opened banners. We should improve performance if possible.

However, @NejcZdovc mentioned this delay is due to reaching out to the reddit API which sometimes takes a bit of time.

Steps to Reproduce

1. launch the latest Brave that includes Greaselion reddit via staging (1.17.43 CR: 86.0.4240.99 in this case)
2. enable rewards either through the rewards panel or brave://rewards
3. visit https://www.reddit.com/user/jsadler-brave and click on the inline BAT icon

Actual result:

Expected result:

Tipping banner shouldn't take ~5-8s to appear.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.17.43 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.15.7 (Build 19H2)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @mandar-brave @rebron @NejcZdovc @LaurenWags

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 10 Version 21H2 (Build 19044.2486)

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.695

Launched 1.44.177 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.695 tipping banner appears quickly (took 1 to ~2 secs) upon clicking on the inline tip icon in https://www.reddit.com/user/jsadler-brave

---

Verification PASSED on

Brave | 1.47.171 Chromium: 109.0.5414.87 (Official Build) (arm64)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | macOS Version 12.5 (Build 21G72)

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.698

Launched 1.44.177 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.695 tipping banner appears quickly (took 1 to ~2 secs) upon clicking on the inline tip icon in https://www.reddit.com/user/jsadler-brave

Screen.Recording.2023-01-20.at.1.30.20.PM.mov