Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle through the most recently used tabs with Ctrl-Tab under brave://settings/appearance is not translated #12149

Closed
btlechowski opened this issue Oct 15, 2020 · 2 comments

Comments

@btlechowski
Copy link

Follow up to #913

Steps to Reproduce

  1. Run Brave in Polish(PL) locale
  2. Open brave://settings/appearance
  3. Check the translation for Cycle through the most recently used tabs with Ctrl-Tab

Actual result:

Cycle through the most recently used tabs with Ctrl-Tab is not translated

image
image

Expected result:

Cycle through the most recently used tabs with Ctrl-Tab is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @mkarolin @rebron

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.18.2

image

@btlechowski
Copy link
Author

btlechowski commented Nov 17, 2020

Fixed by #12559

Verification passed on

Brave 1.17.69 Chromium: 87.0.4280.60 (Official Build) (64-bit)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description

image


Verified passed with

Brave | 1.17.69 Chromium: 87.0.4280.60 (Offizieller Build) (x86_64)
-- | --
Überarbeitung | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
Betriebssystem | macOS Version 10.14.6 (Build 18G6042)

Verified test plan from description. Verified for the below languages:

Polish:
Polish

French:
French

German:
German

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants