-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new Sync section in settings #1183
Comments
Should be similar to brave/brave-core#436 |
@rebron the current implementation isn't as per the spec mentioned in original issue comment. Is this still the expected behaviour? Create new Extensions section in Settings beneath Extensions and before Shield Settings section - Fail(Its below shields settings and there is no extensions setting option) Label section - 'Sync' - Fail (shows as Label in sidebar - 'Sync' - Fail (no sidebar menu) Add item to: 'Manage, add or remove synced devices' - Fail (not implemented yet) Display Device Name of device being synced and Last Activity. - Pass (but shows long date time format and not as per screenshot) cc: @brave/legacy_qa |
Verification passed on
Some follow up issues: Verified passed with
Verification passed on Ubuntu 17.10
|
Thanks for logging the followup issues @btlechowski 👍 |
Description
Create new Extensions section in Settings beneath Extensions and before Shield Settings section
Label section - 'Sync'
Label in sidebar - 'Sync'
Add item to: 'Manage, add or remove synced devices'
This will launch into the Brave Sync UI.
Display Device Name of device being synced and Last Activity.
See design.
Design
The text was updated successfully, but these errors were encountered: