Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new Sync section in settings #1183

Closed
rebron opened this issue Sep 18, 2018 · 4 comments · Fixed by brave/brave-core#918
Closed

create new Sync section in settings #1183

rebron opened this issue Sep 18, 2018 · 4 comments · Fixed by brave/brave-core#918
Assignees
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 18, 2018

Description

Create new Extensions section in Settings beneath Extensions and before Shield Settings section
Label section - 'Sync'
Label in sidebar - 'Sync'
Add item to: 'Manage, add or remove synced devices'
This will launch into the Brave Sync UI.

Display Device Name of device being synced and Last Activity.
See design.

Design

sync-screenshot

@rebron rebron added this to the 1.0 milestone Sep 18, 2018
@rebron rebron added feature/global-settings Settings at browser level independent of shields settings feature/sync browser-laptop-parity design A design change, especially one which needs input from the design team labels Sep 18, 2018
@rebron rebron changed the title create new Sync section create new Sync section in settings Sep 21, 2018
@bsclifton
Copy link
Member

Should be similar to brave/brave-core#436

@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 16, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 20, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Dev Nov 28, 2018
@srirambv
Copy link
Contributor

srirambv commented Dec 11, 2018

@rebron the current implementation isn't as per the spec mentioned in original issue comment. Is this still the expected behaviour?

Create new Extensions section in Settings beneath Extensions and before Shield Settings section - Fail(Its below shields settings and there is no extensions setting option)
image

Label section - 'Sync' - Fail (shows as Brave Sync)
image

Label in sidebar - 'Sync' - Fail (no sidebar menu)
image

Add item to: 'Manage, add or remove synced devices' - Fail (not implemented yet)

Display Device Name of device being synced and Last Activity. - Pass (but shows long date time format and not as per screenshot)
image

cc: @brave/legacy_qa

@btlechowski
Copy link

btlechowski commented Dec 17, 2018

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Some follow up issues:
#2592
#2593
#2594

Verified passed with

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Verified devices listed on brave://sync page
    screen shot 2018-12-17 at 10 18 31 am
  • Verified follow up issues listed above apply to macOS

Verification passed on Ubuntu 17.10

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

@srirambv
Copy link
Contributor

Thanks for logging the followup issues @btlechowski 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants