-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make casing of settings titles / text consistent #8822
Comments
Hey, I would love to give this issue a try! Just to double check, we expect the following changes on the
|
@edwardqiu Keep |
Hey, @rebron. Since this is my first time contributing here, it took me a while to get my dev environment set up. I've made the changes here. I also tested all of them manually on Ubuntu 16.04, except for the following changes: For the exceptions, would there be someone with macOS be able to checkout my branch and test it? |
@jonathanKingston that's a pretty old version - I think we've fixed it since then. Can you please update Brave and report back if it's fixed? |
Ah so it is :') thanks, I thought I was on the auto update path. thanks! Confirmed, it's fine now. Sorry for disturbing! |
@jonathanKingston no worries - got me noticing brave/brave-core#5631 which somehow got past the radar (so many PRs!). Saw that got approved- just needs a rebase. Will try to sort that out |
- Side menu -> "Help Tips" to "Help tips" - Appearance -> Themes -> "Open Web Store" to "Open web store" - Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page" - Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage" - Shields -> "Look & Feel" to "Look & feel" - Extensions -> "Private Window with Tor" to "Private window with Tor" - Extensions -> Get more extensions -> "Open Web Store" to "Open web store" - Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy" - Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging" Fix brave/brave-browser#8822
Verification passed on
Verified test plan from the description Side menu -> "Help Tips" to "Help tips" Appearance -> Themes -> "Open Web Store" to "Open web store" Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page" Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage" Shields -> "Look & Feel" to "Look & feel" Extensions -> "Private Window with Tor" to "Private window with Tor" Extensions -> Get more extensions -> "Open Web Store" to "Open web store" Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy" Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging" Logged #12147 for missing translations Verification passed on
Side menu -> Help Tips to Help tips Appearance -> Themes -> Open Web Store to Open web store Appearance -> Always show bookmarks on New Tab page to Always show bookmarks on new tab page Shields -> Look & Feel to Look & feel Extensions -> **Private Window with Tor" to Private window with Tor Extensions -> Get more extensions -> Open Web Store to Open web store Privacy and security -> WebRTC IP Handling Policy to WebRTC IP handling policy Privacy and security -> Use Google Services for Push Messaging to Use Google services for push messaging Verification PASSED on
|
Test plan
Description
the follow are all cases that don't follow sentence casing in brave://settings
cc: @karenkliu @rebron
The text was updated successfully, but these errors were encountered: