Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make casing of settings titles / text consistent #8822

Closed
pes10k opened this issue Mar 23, 2020 · 9 comments · Fixed by brave/brave-core#5631
Closed

Make casing of settings titles / text consistent #8822

pes10k opened this issue Mar 23, 2020 · 9 comments · Fixed by brave/brave-core#5631
Assignees
Labels
feature/settings good first issue needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 23, 2020

Test plan

  1. Visit brave://settings on any OS (doesn't matter)
  2. Review changes called out at top of Change the following setting names below to sentence case on brave://settings brave-core#5631

Description

the follow are all cases that don't follow sentence casing in brave://settings

- Side menu -> "Help Tips"
- Appearance -> Themes -> "Open Web Store"
- Appearance -> "Always show bookmarks on New Tab page"
- Appearance -> "Pressing Tab on a webpage"
- Shields -> "Look & Feel"
- Extensions -> "Web3 provider for using Dapps"
- Extensions -> "Private Window with Tor"
- Extensions -> Get more extensions -> "Open Web Store"
- Privacy and security -> "WebRTC IP Handling Policy"
- Privacy and security -> "Use Google Services for Push Messaging"

cc: @karenkliu @rebron

@rebron rebron added needs-text-change This change requires some careful wording. feature/settings polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". good first issue labels May 8, 2020
@0xedward
Copy link

0xedward commented May 21, 2020

Hey, I would love to give this issue a try!

Just to double check, we expect the following changes on the brave://settings page:

Text Before Text After Location
Help Tips Help tips Side menu under settings-menu
Open Web Store Open web store under Appearance section
Always show bookmarks on New Tab page Always show bookmarks on new tab page under Appearance section
Pressing Tab on a webpage highlights links, as well as form fields Pressing tab on a webpage highlights links, as well as form fields under Appearance section only on macOS
Look & Feel Look & feel under Shields section
Web3 provider for using Dapps Web3 provider for using dapps under Extensions section
Private Window with Tor Private window with Tor under Extensions section
Open Web Store Open web store description of Get more extensions under Extensions section
WebRTC IP Handling Policy WebRTC IP handling policy under Privacy and Security section
Use Google Services for Push Messaging Use Google services for push messaging under Privacy and Security section

@rebron
Copy link
Collaborator

rebron commented May 21, 2020

@edwardqiu Keep Dapps the same. Everything else looks good.

@0xedward
Copy link

0xedward commented May 22, 2020

Hey, @rebron. Since this is my first time contributing here, it took me a while to get my dev environment set up.

I've made the changes here. I also tested all of them manually on Ubuntu 16.04, except for the following changes:
Appearance -> Themes -> "Open Web Store", because the text change is not reached because of this code block.
Appearance -> "Pressing Tab on a webpage", because this text change is also not reached because it is within this code block.

For the exceptions, would there be someone with macOS be able to checkout my branch and test it?

@0xedward
Copy link

I've also noticed on Linux - there are a few more things that may not be following sentence casing. Would you like these things to be changed to follow sentence casing as well?

image
image
image
image

@jonathanKingston
Copy link

image
I noticed this in the mentioned text changes the & is being escaped in: Version 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)

@bsclifton
Copy link
Member

@jonathanKingston that's a pretty old version - I think we've fixed it since then. Can you please update Brave and report back if it's fixed?

@jonathanKingston
Copy link

jonathanKingston commented Oct 1, 2020

Ah so it is :') thanks, I thought I was on the auto update path. thanks!

Confirmed, it's fine now. Sorry for disturbing!

@bsclifton
Copy link
Member

@jonathanKingston no worries - got me noticing brave/brave-core#5631 which somehow got past the radar (so many PRs!). Saw that got approved- just needs a rebase. Will try to sort that out

bsclifton pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
- Side menu -> "Help Tips" to "Help tips"
- Appearance -> Themes -> "Open Web Store" to "Open web store"
- Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page"
- Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage"
- Shields -> "Look & Feel" to "Look & feel"
- Extensions -> "Private Window with Tor" to "Private window with Tor"
- Extensions -> Get more extensions -> "Open Web Store" to "Open web store"
- Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy"
- Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging"

Fix brave/brave-browser#8822
@bsclifton bsclifton added this to the 1.17.x - Nightly milestone Oct 7, 2020
@btlechowski
Copy link

btlechowski commented Oct 14, 2020

Verification passed on

Brave 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Side menu -> "Help Tips" to "Help tips"
image

Appearance -> Themes -> "Open Web Store" to "Open web store"
Not available on Ubuntu 18.04. It has Classic on clean install

Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page"
image

Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage"
Not available on Ubuntu 18.04

Shields -> "Look & Feel" to "Look & feel"
image

Extensions -> "Private Window with Tor" to "Private window with Tor"
image

Extensions -> Get more extensions -> "Open Web Store" to "Open web store"
image

Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy"
image

Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging"
image

Logged #12147 for missing translations


Verification passed on

Brave | 1.17.39 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

  • Verified test plan from the description

Side menu -> Help Tips to Help tips
image

Appearance -> Themes -> Open Web Store to Open web store
image

Appearance -> Always show bookmarks on New Tab page to Always show bookmarks on new tab page
image

Shields -> Look & Feel to Look & feel
image

Extensions -> **Private Window with Tor" to Private window with Tor
image

Extensions -> Get more extensions -> Open Web Store to Open web store
image

Privacy and security -> WebRTC IP Handling Policy to WebRTC IP handling policy
image

Privacy and security -> Use Google Services for Push Messaging to Use Google services for push messaging
image


Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.17.41 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.15.7 (Build 19H2)
Side Menu Appearance Shields Extensions Privacy & Sec
Screen Shot 2020-10-19 at 11 06 31 PM Screen Shot 2020-10-19 at 11 07 17 PM Screen Shot 2020-10-19 at 11 11 37 PM Screen Shot 2020-10-19 at 11 12 07 PM Screen Shot 2020-10-19 at 11 13 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/settings good first issue needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants