Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #8822: Make casing of settings titles / text consistent #12147

Closed
btlechowski opened this issue Oct 14, 2020 · 1 comment
Closed
Assignees

Comments

@btlechowski
Copy link

btlechowski commented Oct 14, 2020

The text changes are missing translations
Follow up to #8822

Steps to Reproduce

  1. Run Brave in Polish(PL) locale
  2. Open brave://settings
  3. Check the list from Make casing of settings titles / text consistent #8822 for translations

The list:

  • Side menu -> "Help tips"
  • Appearance -> Themes -> "Open web store"
  • Appearance -> "Always show bookmarks on New Tab page"
  • Appearance -> "Press tab on a webpage"
  • Shields -> "Look & feel"
  • Extensions -> "Private window with Tor"
  • Extensions -> Get more extensions -> "Open web store"
  • Privacy and security -> "WebRTC IP handling policy"
  • Privacy and security -> "Use Google services for push messaging"

Actual result:

The texts are not translated
Help tips (Wskazówki)
image

Expected result:

The texts are translated
Help tips (Wskazówki)
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @mkarolin @rebron

@btlechowski
Copy link
Author

Issue fixed by #13040

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Side menu -> "Help tips"
image

Appearance -> Themes -> "Open web store"
image

Appearance -> "Always show bookmarks on New Tab page"
image

Appearance -> "Press tab on a webpage"
image

Shields -> "Look & feel"
image

Extensions -> "Private window with Tor"
image

Extensions -> Get more extensions -> "Open web store"
image

Privacy and security -> "WebRTC IP handling policy"
image

Privacy and security -> "Use Google services for push messaging"
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants