Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the following setting names below to sentence case on brave://settings #5631

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

0xedward
Copy link
Contributor

  • Side menu -> "Help Tips" to "Help tips"
  • Appearance -> Themes -> "Open Web Store" to "Open web store"
  • Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page"
  • Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage"
  • Shields -> "Look & Feel" to "Look & feel"
  • Extensions -> "Private Window with Tor" to "Private window with Tor"
  • Extensions -> Get more extensions -> "Open Web Store" to "Open web store"
  • Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy"
  • Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging"

Resolves brave/brave-browser#8822

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@0xedward 0xedward force-pushed the settings-fix-sentence-casing branch 2 times, most recently from 24af539 to 5d68e32 Compare May 27, 2020 19:22
- Side menu -> "Help Tips" to "Help tips"
- Appearance -> Themes -> "Open Web Store" to "Open web store"
- Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page"
- Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage"
- Shields -> "Look & Feel" to "Look & feel"
- Extensions -> "Private Window with Tor" to "Private window with Tor"
- Extensions -> Get more extensions -> "Open Web Store" to "Open web store"
- Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy"
- Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging"

Fix brave/brave-browser#8822
@bsclifton bsclifton force-pushed the settings-fix-sentence-casing branch from 5d68e32 to babc25b Compare October 2, 2020 16:51
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bsclifton bsclifton merged commit 717a5d5 into brave:master Oct 7, 2020
@bsclifton bsclifton added this to the 1.17.x - Nightly milestone Oct 7, 2020
@bsclifton
Copy link
Member

Thanks again for the contribution, @0xedward - and apologies it took a long time to review this ☹️ We have a growing stack of pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make casing of settings titles / text consistent
4 participants