Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Brave Sync to Sync in settings #2592

Closed
btlechowski opened this issue Dec 17, 2018 · 5 comments · Fixed by brave/brave-core#1114
Closed

Rename Brave Sync to Sync in settings #2592

btlechowski opened this issue Dec 17, 2018 · 5 comments · Fixed by brave/brave-core#1114

Comments

@btlechowski
Copy link

Follow up from #1183

Steps to Reproduce

  1. Go to brave://settings
  2. Scroll down to Brave Sync

Actual result:

The section is named Brave Sync
image

Expected result:

The section is named Sync

Brave version (brave://version info)

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

@rebron @cezaraugusto @brave/legacy_qa

@LaurenWags
Copy link
Member

Reproduces on macOS. Additionally, do we want to change the wording in the box from 'Access Brave Sync...' to 'Access Sync...'?

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@cezaraugusto
Copy link
Contributor

moving to 0.59 per last sync meeting

@darkdh
Copy link
Member

darkdh commented Dec 17, 2018

If we rename this, we also need to rename the menu item
screen shot 2018-12-17 at 11 31 36

@btlechowski
Copy link
Author

Reproduces on Ubuntu 17.10

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 29, 2018

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows
  • Verified the STR mentioned in the issue.
    image

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

screen shot 2019-01-02 at 1 32 09 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants