Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Brave Sync to Sync in settings #1114

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Rename Brave Sync to Sync in settings #1114

merged 1 commit into from
Dec 18, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Dec 17, 2018 •
edited by darkdh
Loading

fix brave/brave-browser#2592

Test Plan

  1. Go to brave://settings
  2. Ensure Sync is shown as Sync and not Brave Sync

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@darkdh
Copy link
Member

darkdh commented Dec 17, 2018

what about <message name="IDS_SHOW_BRAVE_SYNC" desc="The show brave sync menu in the app menu">?
screen shot 2018-12-17 at 11 31 36

@cezaraugusto
Copy link
Contributor Author

way to go

@cezaraugusto cezaraugusto merged commit eaf047f into master Dec 18, 2018
@cezaraugusto cezaraugusto deleted the ca-2592 branch December 18, 2018 19:11
cezaraugusto added a commit that referenced this pull request Dec 18, 2018
@cezaraugusto
Merge pull request #1114 from brave/ca-2592
04145ad 
Rename `Brave Sync` to `Sync` in settings
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Dec 18, 2018 •
edited by darkdh
Loading

master eaf047f
0.60.x 04145ad
0.59.x 0362f40

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

darkdh pushed a commit that referenced this pull request Dec 20, 2018
@cezaraugusto @darkdh
Merge pull request #1114 from brave/ca-2592
0362f40 
Rename `Brave Sync` to `Sync` in settings
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

Rename Brave Sync to Sync in settings
4 participants
@cezaraugusto @darkdh @rebron @bbondy