Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update appearance section in settings #1222

Closed
8 tasks
rebron opened this issue Sep 21, 2018 · 4 comments
Closed
8 tasks

update appearance section in settings #1222

rebron opened this issue Sep 21, 2018 · 4 comments
Assignees
Labels
closed/invalid closed/not-actionable closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 21, 2018

Description

  • Style Appearance section with Brave styling.
  • Keep label section 'Appearance' and sidebar navigation label 'Appearance'.
  • Create 'Themes' section at the top with drop down display for light and dark themes. [This is currently labeled 'Brave colors'].
  • Drop down list for themes should display 'Light', and 'Dark'
  • Remove 'Theme' section that points to Chrome Web Store.
  • Add Address bar size section label 'Address bar size' with drop down menu with these two options 1) default to 'Centered' and 2) 'Full width'
  • No change other than styling for Show home button, Show bookmarks, Font size, Customize fonts, and Page zoom.
  • Replace text 'Pressing Tab on a webpage highlights links, as well as form fields' to 'Highlight links and form fields by pressing tabs'

Design

screen shot 2018-10-03 at 1 48 13 pm

I'll update the mock with appropriate labels currently labeled 'User interface colors' and 'Url Bar style' but should be 'Themes' and 'Address bar size'

@rebron rebron added this to the 1.0 milestone Sep 21, 2018
@rebron
Copy link
Collaborator Author

rebron commented Sep 21, 2018

@rossmoody and @petemill. Mock has the Themes section pointer to Chrome Web Store removed. Possibly need to special case if a user installs a theme from the Chrome Web Store, having the setting show in order to 'Reset to Default'. I'm inclined to hide and revisit post 1.0 to decide how to support CWS themes.
screen shot 2018-09-20 at 9 40 26 pm

@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 22, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@petemill
Copy link
Member

Not sure we can remove the 'theme' section here @rebron - this is the only way to remove a theme if someone installs a theme from the extensions store. This is why we differentiated the title Brave Colors with Themes - so that you can choose a theme from the store and have the rest of the non-theme colors be light or dark.

We may also want to remove the option for Dark / Light considering that Chromium has followed many other popular apps patterns by supporting OS-specified light / dark mode. Though we can revisit that decision when we implement chromium's dark mode properly in Brave, and see how easy it is to keep both mechanisms (OS-provided as well as user-provided settings).

@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 14, 2019
@rebron
Copy link
Collaborator Author

rebron commented Mar 14, 2019

@rossmoody we need an updated mock, this one is a bit stale especially since we introduced Rewards button setting and chromium added the warning with command+Q.

@rebron rebron self-assigned this Mar 14, 2019
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/not-actionable labels May 20, 2019
@rebron
Copy link
Collaborator Author

rebron commented May 20, 2019

This issue is stale. Closing in favor of #4508

@rebron rebron closed this as completed May 20, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid closed/not-actionable closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Development

No branches or pull requests

5 participants