Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change label to 'address bar' instead of 'location bar' #4508

Closed
rebron opened this issue May 20, 2019 · 1 comment · Fixed by brave/brave-core#2519
Closed

change label to 'address bar' instead of 'location bar' #4508

rebron opened this issue May 20, 2019 · 1 comment · Fixed by brave/brave-core#2519
Assignees
@petemill
Labels
feature/global-settings Settings at browser level independent of shields settings needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented May 20, 2019 •
edited by bsclifton
Loading

Test plan

  1. Open brave://settings
  2. verify text says Use wide address bar (not Use wide location bar)

Description

Under brave://settings in Appearance section, for consistency change label to read:
'Use wide address bar'

instead of:
'Use wide location bar'

Current screen:

Screen Shot 2019-05-20 at 12 51 37 PM
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". feature/global-settings Settings at browser level independent of shields settings labels May 20, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels May 20, 2019
@rebron rebron mentioned this issue May 20, 2019
Closed
8 tasks
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label May 20, 2019
@petemill petemill mentioned this issue May 28, 2019
Merged
28 tasks
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 1, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Aug 1, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

image

This was referenced Aug 2, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/global-settings Settings at browser level independent of shields settings needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Settings: location bar -> address bar brave/brave-core
6 participants
@petemill @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya