Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test run on Linux for 0.68.x - Beta #5514

Closed
kjozwiak opened this issue Aug 2, 2019 · 2 comments
Closed

Manual test run on Linux for 0.68.x - Beta #5514

kjozwiak opened this issue Aug 2, 2019 · 2 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2019

Per release specialty tests

  • Delay incrementing shields counter until first render.(#888)
  • Show full url like in Chrome.(#2192)
  • Block element via selector context menu is not translated to other locales.(#3094)
  • Update extension dialogue text so it's not as misleading.(#3231)
  • Shields Panel and Rewards Panel are not translated to Norwegian.(#3425)
  • Prevent sliding notification animation in omnibar for autoplay blocks. .(#3751)
  • Ads not shown if a background tab is playing video.(#3779)
  • Brave is now intercepting media keys.(#3807)
  • Support attention for Vimeo auto contribution.(#4017)
  • Ad Notification has a settings button in Gnome.(#4231)
  • Add Vimeo support (tip/panel).(#4391)
  • Re-implement statistical voting for auto-contribute.(#4475)
  • BAT is sometimes truncated on panel for 'Tip this site monthly' value.(#4503)
  • Change label to 'address bar' instead of 'location bar'.(#4508)
  • A-c table is not being correctly updated when excluding publishers.(#4561)
  • Shields should offer a shortcut to allow all scripts once.(#4567)
  • Thank you banner no longer auto dismisses after about 3 seconds.(#4590)
  • Implement Reddit Panel For Tipping.(#4745)
  • Switching Ads off and then back on stops Ad notifications from showing unless you quit the browser.(#4748)
  • Use new adblock-rust library.(#4793)
  • Deliver Ads at a consistent rate on mobile devices.(#4797)
  • Fix ads should only be sustained after the page has fully loaded.(#4798)
  • Implement staging environment support for Android Ads.(#4799)
  • History should always respect wait time when showing Ads for mobile.(#4800)
  • Fix retry failed confirmations only if we are not currently retrying.(#4801)
  • Split big bat_contribution file in ledger.(#4807)
  • Ads Rewards Grant Panel changes!.(#4814)
  • Processing ballots is not working.(#4881)
  • Combine Trackers Blocked and Ads Blocked on NTP.(#5273)
  • URL is hidden when searching.(#5283)

Installer

  • Check that installer is close to the size of last release
  • Check signature: If OS Run spctl --assess --verbose /Applications/Brave-Browser-Beta.app/ and make sure it returns accepted. If Windows right click on the brave_installer-x64.exe and go to Properties, go to the Digital Signatures tab and double click on the signature. Make sure it says "The digital signature is OK" in the popup window

Data(Upgrade from previous release)

  • Make sure that data from the last version appears in the new version OK
  • With data from the last version, verify that
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Unpinned tabs can be pinned
    • Sync chain created in previous version is retained
    • Social media blocking buttons changes are retained

About pages

  • Verify that chrome:// forwards to brave://
  • Verify brave://adblock loads adblock page
  • Verify brave://newtab loads a new tab
  • Verify brave://rewards loads Brave rewards page
  • Verify brave://settings loads Brave settings page
  • Verify brave://version correctly shows Brave version and Chromium version
  • Verify brave://welcome loads the welcome page

Import tests

  • Verify that you can import bookmarks, cookies, history, passwords from Google Chrome
  • Verify that you can import bookmarks, cookies, history, passwords, autofill and search engines from Firefox
  • Verify that you can import bookmarks from Edge
  • Verify importing Bookmark HTML file retains the folder structure on a clean profile

Context menus

  • Verify Block element via selector removes a CSS element from page without reloading
  • Verify Clear all CSS rules for this sites removes the blocked element after page reload
  • Verify Clear all CSS rules for all sites removes the rule and loads all elements for all pages

Extensions/Plugins tests

  • Verify one item from Brave Update server is installable (Example: Ad-block DAT file on fresh extension)
  • Verify one item from Google Update server is installable (Example: Extensions from CWS)
  • Verify PDFJS, Torrent viewer extensions are installed automatically on fresh profile and cannot be disabled
  • Verify older version of an extension gets updated to new version via Google server
  • Verify older version of an extension gets updated to new version via Brave server
  • Verify magnet links and .torrent files loads Torrent viewer page and able to download torrent
  • Use an old profile to verify extension updates work correctly.

CWS

  • Verify installing ABP from CWS shows warning message NOT A RECOMMENDED BRAVE EXTENSION!but still allows to install the extension
  • Verify installing LastPass from CWS doesn't show any warning message
  • Verify installing an extension that is not vetted by Brave gets blocked

Flash tests

  • Test that Flash gets blocked by default when installed
  • Test that once you allow Flash, it turns into a click to play area, and loads flash when allowed

PDF

Widevine

  • Verify Widevine Notification is shown when you visit Netflix for the first time
  • Test that you can stream on Netflix on a fresh profile after installing Widevine

Geolocation

Crash Reporting

  • Check that loading brave://crash causes the new tab to crash
  • Check that brave://crashes lists all the crashes and includes both Crash Report ID & Local Crash ID
  • Verify the crash ID matches the report on brave stats

Performance test

Each start should take less than 7 seconds

  • Enable only rewards
  • Only import a large set of bookmarks
  • Combine rewards, and a large set of bookmarks

Bravery settings

Fingerprint Tests

Content tests

  • Open a page with an input control and type some misspellings on a textbox, make sure they are underlined
  • Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text
  • Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run)

Brave Ads

  • Verify when you enable Rewards from panel or brave://rewards, Ads are enabled by default
  • Verify Ads UI (panel, settings, etc) shows when in a region with Ads support
  • Verify Ads UI (panel, settings, etc) does not show when in a region without Ads support. Verify the Ads panel does show the 'Sorry! Ads are not yet available in your region.' message.
  • Verify when the system language is English, the Browser language is French, and you are in one of the supported regions, Ad notifications are still served to you.
  • Verify you are served Ad notifications when Ads are enabled
  • Windows only: Verify when Focus Assist is set to alarms only, Ads are not served to the user but are available in the Notification Center
  • Verify when Ads are toggled off, there are no Ad messages in the logs
  • Verify when Rewards are toggled off (but Ads were not explicitly toggled off), there are no Ads logs recorded
  • Verify view/click/dismiss/landed ad notifications show in confirmations.json
  • Verify pages you browse to are being classified in the logs
  • Verify tokens are redeemed by viewing the logs (you can use --rewards=debug=true to shorten redemption time)
  • Verify Ad is not shown if a tab is playing media and is only shown after it stops playing
  • Upgrade Cases
    • Verify when updating from the previous version Ads info in the panel is not lost
    • Update to latest version from 0.62.51 (or a version without Ads available). Verify you are notified to try ads via a BAT logo notification but Ads are not automatically turned on for you.
    • Update to latest version from some Ads enabled versions (0.63.x, 0.64.x). Verify Ads status (on/off) is the same as it was prior to update.

Rewards

  • Verify wallet is auto created after enabling rewards
  • Verify account balance shows correct BAT and USD value
  • Verify you are able to restore a wallet
  • Verify wallet address matches the QR code that is generated under Add funds
  • Verify actions taken (claiming grant, tipping, auto-contribute) display in wallet panel
  • Verify adding funds via any of the currencies flows into wallet after specified amount of time
  • Verify adding funds to an existing wallet with amount, adjusts the BAT value appropriately
  • Verify monthly budget shows correct BAT and USD value
  • Verify you are able to exclude a publisher from the auto-contribute table by clicking on the x in auto-contribute table and popup list of sites
  • Verify you are able to exclude a publisher by using the toggle on the Rewards Panel
  • Verify when you click on the BR panel while on a site, the panel displays site specific information (site favicon, domain, attention %)
  • Verify when you click on Send a tip, the custom tip banner displays
  • Verify you are able to make one-time tip and they display in tips panel
  • Verify you are able to make recurring tip and they display in tips panel
  • Verify you can tip a verified publisher
  • Verify you can tip a verified YouTube creator
  • Verify tip panel shows a verified checkmark for a verified publisher/verified YouTube creator
  • Verify tip panel shows a message about unverified publisher
  • Verify BR panel shows message about an unverified publisher
  • Verify you are able to perform a contribution
  • Verify if you disable auto-contribute you are still able to tip regular sites and YouTube creators
  • Verify that disabling Rewards and enabling it again does not lose state
  • Verify that disabling auto-contribute and enabling it again does not lose state
  • Adjust min visit/time in settings. Visit some sites and YouTube channels to verify they are added to the table after the specified settings
  • Upgrade from older version
    • Verify the wallet balance is retained and wallet backup code isn't corrupted
    • Verify auto-contribute list is not lost after upgrade
    • Verify tips list is not lost after upgrade
    • Verify wallet panel transactions list is not lost after upgrade

Social-media blocking settings

Sync

  • Verify you are able to create a sync chain and add a mobile/computer to the chain
  • Verify you are able to join an existing sync chain using code words
  • Verify the device name is shown properly when sync chain is created
  • Verify you are able to add a new mobile device to the chain via QR code/code words
  • Verify newly created bookmarks get sync'd to all devices on the sync chain
  • Verify existing bookmarks on current profile gets sync'd to all devices on the sync chain
  • Verify folder structure is retained after sync completes
  • Verify bookmarks don't duplicate when sync'd from other devices
  • Verify removing bookmark from device gets sync'd to all devices on the sync chain
  • Verify adding/removing a bookmark in offline mode gets sync'd to all devices on the sync chain when device comes online
  • With only two device in chain, verify removing the other device resets the sync on b-c as well

Tor Tabs

  • Visit https://check.torproject.org in a Tor window, ensure its shows success message for using a Tor exit node
  • Visit https://check.torproject.org in a Tor window, note down exit node IP address. Do a hard refresh (Ctrl+Shift+R/Cmd+Shift+R), ensure exit IP changes after page reloads
  • Visit https://check.torproject.org in a Tor window, note down exit node IP address. Click New Tor Identity for this site in app menu, ensure the exit node IP address changes after page is reloaded
  • Visit https://protonirockerxow.onion/ in a Tor window, ensure login page is shown
  • Visit http://pdf995.com in a Tor window, should warn about connecting to HTTP site
  • Visit https://browserleaks.com/geo in a Tor window, ensure location isn't shown
  • Visit https://diafygi.github.io/webrtc-ips/ in a Tor window with block all fingerprinting, ensure WebRTC is blocked and no IP is shown
  • Visit https://diafygi.github.io/webrtc-ips/ in a Tor window, disable shields, ensure WebRTC is blocked and no IP is shown
  • Verify Flash doesn't work on Tor window even if it is enabled in brave://settings/content/flash
  • Verify Torrent viewer doesn't load in a Tor window and warns when trying to load a torrent/magnet link in a Tor window
  • Verify Google Widevine doesn't load in Tor window and doesn't prompt Google Windevine notification in URL bar
  • Ensure you are able to download a file in Tor window. Verify all Download/Cancel, Download/Retry and Download works in Tor window
  • Disconnect network and open a Tor window, should show modal to retry connection or relaunch Tor window to connect

Cookie and Cache

  • Go to http://samy.pl/evercookie/ and set an evercookie. Check that going to prefs, clearing site data and cache, and going back to the evercookie site does not remember the old evercookie value

Session storage

  • Temporarily move away your browser profile and test that a new profile is created when browser is launched
    • macOS - ~/Library/Application\ Support/BraveSoftware/
    • Windows - %userprofile%\appdata\Local\BraveSoftware\
    • Linux(Ubuntu) - ~/.config/BraveSoftware/
  • Test that windows and tabs restore when closed, including active tab
    • Ensure that the tabs in the above session are being lazy loaded when the session is restored

Update tests

  • Verify visiting brave://settings/help triggers update check
  • Verify once update is downloaded, prompts to Relaunch to install update

Chromium upgrade tests

  • Verify brave://gpu on Brave and chrome://gpu on Chrome are similar for the same Chromium version on both browsers

Adblock

  • Verify referrer blocking works properly for TLD+1. Visit https://technology.slashdot.org/ and verify adblock works properly similar to https://slashdot.org/

Components

  • Delete Adblock folder from browser profile and restart browser. Visit brave://components and verify Brave Ad Block Updater downloads and update the component. Repeat for all Brave components
  • Restart the browser, load brave://components, wait for 8 mins and verify that no component shows any errors
  • Verify Brave Local Data Updater, Brave Ad Block Updater, Brave Tor Client Updater (Mac), PDF Viewer (PDF.js), Brave HTTPS Everywhere Updater have non-zero version numbers

Keyboard Shortcuts (WIP)

Rewards Media (To be verified on YouTube and Twitch) (WIP)

@Luzifer
Copy link

Luzifer commented Aug 3, 2019

Refs Widevine on Netflix:

  • Version: 0.68.116 Chromium: 76.0.3809.87 (Official Build) unknown (64-bit)
  • Widevine is NOT listed in brave://components (see Linux doesn't list Widevine component module in brave://components #3955)
  • Bitmovin DRM Demo lists EME widevine as supported
    • Playback fails though: Unable to instantiate a key system supporting the required combinations (DRM_NO_KEY_SYSTEM)
  • Netflix does NOT play (neither in profile working before update nor private window or newly created profile)
    • Steps listed by Netflix in their error message are not possible because Widevine not being listed in brave://components
  • No site (Netflix, Bitmovin, Amazon Prime) is showing Widevine install prompt (I assume because of previously installed Widevine component and successful detection of the EME)

Edit: Solve the issue for me by

  • removing ~/.config/BraveSoftware/Brave-Browser/WidevineCdm/libwidevinecdm.so
  • restarting the browser
  • which then yields the Widevine installation prompt
  • restarting the browser again

Though nothing with the shared object changed during this process:

# sha1sum *
4d3e1f3070990d9c83f7b320a8f2628ea5af912c  libwidevinecdm.so
4d3e1f3070990d9c83f7b320a8f2628ea5af912c  libwidevinecdm.so.bak

So on a fresh 0.68.x installation everything should work as expected, just on an updated installation things could be wonky.

Screenshots

Bitmovin

image

Netflix

image

@btlechowski
Copy link

LGTM

Verification passed on

Brave 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants