-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine Trackers Blocked and Ads Blocked on NTP #5273
Comments
cc: @tomlowenthal for label text for this metric. |
I'd like to just collapse into "Trackers blocked". |
Question that is probably unlikely, but what happens when you get to 1M + ads blocked, do the numbers dynamically shift to make space? Is there a risk of overlapping? This is especially relevant if we are merging ads and trackers as that number will grow much faster... |
@EyanGoldman yes, the stats row expands to fit larger numbers |
Uplift of #2971 for fixing issue brave/brave-browser#5273
Verified passed with
Verification passed on
Verification passed on
|
Description
On the new tab page, Trackers Blocked and Ads Blocked should be combined into a single count and labeled appropriately. For the backend, tracking-protection lib will move into the ad-block lib so good time to simplify and relabel this metric.
Current result:
Expected result:
Single metric with label
[Count]
Ads & Trackers Blocked
The text was updated successfully, but these errors were encountered: