-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine trackers blocked and ads blocked on NTP #2950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and verified that ads and trackers blocked are now aggregated into one number - checkouts on storybooks too
nit: while we are on this issue, I was wondering if it be possible to keep #B02FFB (purple) as the color rather than #4C54D2 (blue) IMO the blue is hard to differentiate with certain background images and this holds especially true with the gradient 😅
@imptrx good one. @karenkliu thoughts on #2950 (review)? |
@imptrx Please set the label to be "Ads and Trackers blocked" for now and use #A0A5EB (light purple) instead of the blue. (This is a stopgap measure until we work on fixing the labels so that it matches the Shields panel labels). |
Let's stick with "Ads and Trackers blocked" for now as @karenkliu mentioned and can revisit labels to match shields later. We'll surely get questions on the removal of "Ads blocked" and fewer questions if simply combining the labels. |
12500b4
to
9b232ff
Compare
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified new text and combined tracker 🛳️🇮🇹
close brave/brave-browser#5273
Test Plan:
The combination of ads and trackers is now called "trackers blocked" only, per brave/brave-browser#5273 (comment).
Reviewer Checklist:
After-merge Checklist:
changes has landed on.