Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant obsolete brave/tracking-protection #2971

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 22, 2019

Fix brave/brave-browser#5389

It's been moved inside of the rust ad-block lib

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 0.69.x - Nightly milestone Jul 22, 2019
@bbondy bbondy self-assigned this Jul 22, 2019
@bbondy bbondy added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jul 25, 2019
@bbondy bbondy modified the milestones: 0.69.x - Dev, 0.70.x - Nightly Jul 25, 2019
@bbondy bbondy removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jul 25, 2019
@bbondy
Copy link
Member Author

bbondy commented Jul 25, 2019

rebased and pushed

emerick
emerick previously approved these changes Jul 25, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

It's been moved inside of the rust ad-block lib
bbondy added a commit that referenced this pull request Aug 3, 2019
@bbondy bbondy mentioned this pull request Aug 3, 2019
@bsclifton bsclifton deleted the tp-lib-removal branch August 5, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant brave/tracking-protection lib usage
3 participants