Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block element via selector context menu is not translated to other locales #3094

Closed
btlechowski opened this issue Jan 25, 2019 · 4 comments · Fixed by brave/brave-core#2692
Closed

Comments

@btlechowski
Copy link

btlechowski commented Jan 25, 2019

Steps to Reproduce

  1. Change locale
  2. Open a page
  3. Right click on the page
  4. Click Brave from the context menu

Locales checked: Polish, Czech, German, Dutch, Danish, Finnish, Italian, Japanese, Korean, Norwegian, Russian, Spanish.

Actual result:

Strings that are not translated:
Block element via selector
Clear CSS rules for this site
Clear CSS rules for all sites

image

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

cc @brave/legacy_qa @bbondy

@bbondy
Copy link
Member

bbondy commented Jan 25, 2019

This is part of the brave extension so as long as it is localized there it should be fixed when we fix that localization.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 29, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 29, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@rebron
Copy link
Collaborator

rebron commented May 31, 2019

@btlechowski While checking locales, can you revisit this one as well? cc @Snuupy

@btlechowski
Copy link
Author

Still reproducible

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta (64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Windows 7 Service Pack 1 (Build 7601.24465)
Brave 0.68.39 Chromium: 75.0.3770.87 (Oficjalna wersja)nightly (64-bitowa)
Wersja 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24465)

image

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 12, 2019
@Snuupy Snuupy self-assigned this Jun 12, 2019
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 18, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Aug 5, 2019

Verified passed with

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

image

image

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants