Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attention for Vimeo auto contribution #4017

Closed
mandar-brave opened this issue Apr 5, 2019 · 3 comments · Fixed by brave/brave-core#2247
Closed

Support attention for Vimeo auto contribution #4017

mandar-brave opened this issue Apr 5, 2019 · 3 comments · Fixed by brave/brave-core#2247
Assignees

Comments

@mandar-brave
Copy link

mandar-brave commented Apr 5, 2019

Support capturing attention for Vimeo as a platform.
Replicate YT functionality; including support for unverified Vimeo publishers to be treated the same way as unverified publishers elsewhere on other channels.

In phase 1 we will add support for auto-contribution.
In phase 2 we will add panel/tip support #4391

cc @NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 5, 2019
@NejcZdovc
Copy link
Contributor

in first iteration we will support only AC functionality. @mandar-brave please create separate issue for panel/tipping support

@NejcZdovc NejcZdovc self-assigned this Apr 5, 2019
@NejcZdovc NejcZdovc removed their assignment Apr 10, 2019
@NejcZdovc
Copy link
Contributor

blocked on #4005

@NejcZdovc NejcZdovc self-assigned this Apr 17, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 17, 2019
@NejcZdovc NejcZdovc removed the blocked label Apr 17, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 25, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 10, 2019
@NejcZdovc NejcZdovc changed the title Support attention for Vimeo Support attention for Vimeo auto contribution May 10, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 14, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 7, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 10, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 10, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 25, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 19, 2019

Verification passed on

Brave 0.68.104 Chromium: 75.0.3770.100 (Official Build) dev (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

BR panel:

image

A-C table:

image

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Screen Shot 2019-08-19 at 2 32 10 PM
Screen Shot 2019-08-19 at 2 32 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants