Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3A for New Tab Page #12267

Closed
bsclifton opened this issue Oct 22, 2020 · 4 comments · Fixed by brave/brave-core#6924
Closed

P3A for New Tab Page #12267

bsclifton opened this issue Oct 22, 2020 · 4 comments · Fixed by brave/brave-core#6924
Assignees
Labels

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 22, 2020

Test plan

Verify new questions are on official P3A page:
https://github.com/brave/brave-browser/wiki/P3A

Brave.NTP.SponsoredImagesEnabled

  1. Fresh profile
  2. Launch Brave and verify sponsored images are enabled by default
  3. Visit brave://local-state and ensure that you see Brave.NTP.SponsoredImagesEnabled with a value of 1
  4. In a new tab, visit brave://settings/newTab and toggle sponsored images to OFF
  5. Go back to brave://local-state, refresh, and verify Brave.NTP.SponsoredImagesEnabled with a value of 0
  6. Open new tab, click Customize in bottom right
  7. On NTP settings modal, toggle sponsored images ON
  8. Go back to brave://local-state, refresh, and verify Brave.NTP.SponsoredImagesEnabled with a value of 1

Brave.NTP.CustomizeUsageStatus

  1. Fresh profile
  2. Visit brave://local-state and ensure that you see Brave.NTP.CustomizeUsageStatus with a value of 0
  3. Open a new tab; click Customize and then close the tab
  4. Visit brave://local-state and ensure that you see Brave.NTP.CustomizeUsageStatus with a value of 1
  5. Open a new tab; click Customize and then toggle backgrounds to OFF
  6. Visit brave://local-state and ensure that you see Brave.NTP.CustomizeUsageStatus with a value of 2

Brave.NTP.NewTabsCreated and Brave.NTP.SponsoredNewTabsCreated

NOTE: For this test, keep track of how many sponsored images you see on each "day"
Before starting the test, ensure your region has sponsored images! 😄

  1. Set your system clock to 2 days ago
  2. Fresh profile
  3. Launch Brave and open 4 new tabs
  4. Visit brave://local-state and ensure that you see:
  • Search for p3a_new_tabs_created and there should be an array with one entry; 4
  • Brave.NTP.NewTabsCreated should exist and have an entry for 2 (2 being "4 to 8")
  1. Close Brave; update system clock to 1 day ago
  2. Launch Brave and open 9 new tabs
  3. Visit brave://local-state and ensure that you see:
  • Search for p3a_new_tabs_created and there should be an array with two entries; 4 and 9
  • Brave.NTP.NewTabsCreated should exist and have an entry for 3 (3 being "9 to 20")
  1. Close Brave; update system clock to today
  2. Launch Brave and open 2 new tabs
  3. Visit brave://local-state and ensure that you see:
  • Search for p3a_new_tabs_created and there should be an array with three entries; 4, 9, and 3
  • Brave.NTP.NewTabsCreated should exist and have an entry for 3 (3 being "9 to 20"; highest value in the past 7 days)
  1. You should have seen some sponsored images. Make note of how many you saw on each "date". You should be able to match this on brave://local-state to the values in the array if you search for p3a_sponsored_new_tabs_created
  2. Work out what the ratio should be; so given the highest number from p3a_sponsored_new_tabs_created for the week (ex: you saw 3 on one day) divided by highest number from p3a_new_tabs_created for the week (ex: 9), as a percentage. For example: (highest # of sponsored images (3) / highest # of tabs (9) * 100) = 33%. In this example, you can search for Brave.NTP.SponsoredNewTabsCreated on brave://local-state and the answer would be 4 (30% to < 40%)

Description

Adding questions so that we can understand more about new tab page usage; specifically with regards to customizing and sponsored image display.

Question 1: (Brave.NTP.NewTabsCreated)
On average, how many New Tab Pages did you create per day?

0) 0 
1) 1 to 3
2) 4 to 8
3) 9 to 20
4) 21 to 50
5) 51 to 100
6) More than 100

Question 2: (Brave.NTP.SponsoredImagesEnabled)
Is the sponsored new tab page option enabled?

0) Disabled
1) Enabled

Question 3: (Brave.NTP.SponsoredNewTabsCreated)
On average, how many of the New Tab Pages you saw per day were sponsored?

Answers:

0) 0%
1) > 0% and < 10%
2) 10% to < 20%
3) 20% to < 30%
4) 30% to < 40%
5) 40% to < 50%
6) 50% or more

Question 4: (Brave.NTP.CustomizeUsageStatus)
On the New Tab Page, did you click the Customize Settings icon?

Answers:

0) No
1) Yes, but I didn't make any changes
2) Yes, and I did make a change
@bbondy
Copy link
Member

bbondy commented Oct 30, 2020

Please do not assign milestones until issues are closed. If this is release blocking though it can stay but add a release/blocking label.
Screen Shot 2020-10-30 at 1 22 17 PM
https://github.com/brave/brave-browser/wiki/Triage-Guidelines#milestones-and-issues

@bbondy bbondy removed this from the 1.18.x - Nightly milestone Oct 30, 2020
@kjozwiak
Copy link
Member

@bsclifton mind checking to see if we're getting the correct data from the above questions on Nightly/BETA? If things look good, we can consider this as QA complete in spirit of saving some time. The above was also QA'd once via brave/brave-core#6924 (comment) so it was checked.

@bsclifton
Copy link
Member Author

@aekeus helped confirm we're seeing data on RELEASE (via release candidate) in DM 😄👍 Should be good to go!

@kjozwiak kjozwiak added QA/No and removed QA/Blocked labels Nov 16, 2020
@kjozwiak
Copy link
Member

@aekeus helped confirm we're seeing data on RELEASE (via release candidate) in DM 😄👍 Should be good to go!

As per above, @aekeus verified that we were getting data and everything looked correct. As per #12267 (comment), adding QA/No. QA also made sure the above was working before we uplifted via brave/brave-core#6924 (comment) so there was some verification 👍 Thanks again for the double check @aekeus and the help @bsclifton.

@bsclifton bsclifton added the feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants