-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] no hover text for Tip button on Twitter #12536
Labels
Comments
I believe we were relying on Twitter's standard CSS and definitions for this, but they removed all of the hover text on their buttons from what I can tell. Not sure if we should also follow suit, especially given that the button already says "Tip". |
@mkarolin Will just remove tooltips since there are issues on some sites where tooltips can't appear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When you hover over the in-line tip button on Twitter there's no hover text (ex. "Send a tip" or similar). This hover text does appear for GitHub in-line tip buttons.
Steps to Reproduce
Actual result:
"Tip" changes to orange, but no hover text:
Expected result:
Something similar to GH:
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @emerick @NejcZdovc
The text was updated successfully, but these errors were encountered: