[Desktop] race condition with Greaselion and localizations #12264

LaurenWags · 2020-10-21T18:18:18Z

Description

I noticed that the "Tip" text wasn't displaying next to the in-line BAT logo on twitter. When this happens, if you click on the in-line tip icon, sometimes (not always) nothing will happen (no tip banner opens).

Per discussion with @emerick there is a race condition with localizations that causes the text to not display properly. A browser restart fixes this.

Steps to Reproduce

Unsure if the below will work 100% of the time:

Clean profile
Enable Rewards
Navigate to a twitter page like twitter.com/brave
Look at the tweets on the page.
Click on icon.

Actual result:

No "Tip" text next to the BAT logo and when you click on it, the banner may or may not open.

Expected result:

should say "Tip" and "Tip" should change to orange when hovered over. Should be able to click on the BAT logo/text and the tip banner should be displayed.

Reproduces how often:

intermittent, race condition

Brave version (brave://version info)

Brave	1.17.45 Chromium: 86.0.4240.99 (Official Build) dev (x86_64)
Revision	002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

Can you reproduce this issue with the current release? n/a
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @emerick @NejcZdovc

emerick · 2020-10-21T18:21:59Z

We think this is caused by or related to this upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=83549.

GeetaSarvadnya · 2020-10-22T08:58:22Z

Reproduced in Windows 10 x64 - 1.18.2

LaurenWags · 2020-10-28T13:51:18Z

Reproduces on Reddit as well:

Brave	1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

btlechowski · 2020-11-04T04:31:02Z

Reproduced on

Brave	1.17.59 Chromium: 86.0.4240.183 (Official Build) dev (64-bit)
Revision	0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS	Ubuntu 18.04 LTS

Steps:

With rewards enabled, open https://old.reddit.com/user/alex_the_brave in a new tab

Note: Browser restart fixes the issue
Note: Page reload does not fix the issue

LaurenWags · 2020-11-04T19:56:20Z

This happens almost every time I open a GH page:

Close/reopen of the browser fixes it:

Brave | 1.17.60 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
-- | --
Revision | 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS | macOS Version 10.14.6 (Build 18G6032)

LaurenWags · 2020-11-10T14:47:48Z

Removed intermittent-issue as this happens about 80-90% of the time for me. It's incredibly prevalent.

emerick · 2020-11-12T18:39:16Z

When this fails for me, it's due to the contents of the following directory being deleted: C:\Users\emerick\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default\Extensions.

It seems like there are two problems here:

Brave never explicitly deletes its Greaselion extension directories on shutdown, so those directories continue to proliferate in the temp directory. @jonathansampson also noticed this on his computer.
Something periodically comes along and completely wipes out the extensions temp directory (see above). I'm not sure if that's just some housekeeping that Chromium does, but when that occurs our localizations stop working (I guess they're not read into memory?)

jonathansampson · 2020-11-13T02:24:45Z

I often see Failed to fetch user details for : Missing auth headers as well. You can trigger this message by switching away from Twitter, and back. It's fairly easy to reproduce in my experience. This makes sense, since I am apparently also never able to actually trigger the handleOnSendHeadersWebRequest method either:

const handleOnSendHeadersWebRequest = (mediaType: string, details: any) => {
  if (mediaType !== types.mediaType || !details || !details.requestHeaders) {
    return
  }
  if (auth.processRequestHeaders(details.requestHeaders)) {
    tipping.configure()
  }
}

That handler is registered successfully, but never called:

webRequestHandlers.registerOnSendHeadersWebRequest(
  types.mediaType,
  types.sendHeadersUrls,
  types.sendHeadersExtra,
  handleOnSendHeadersWebRequest)
tabHandlers.registerOnUpdatedTab(types.mediaType, handleOnUpdatedTab)

emerick · 2020-11-13T02:46:00Z

@jonathansampson I've got a fix for the localizations bug teed up, I just need to clean it up and PR it (most likely in the morning at this point).

I have seen that Twitter error message, but I think it's probably unrelated to this. As long as tipping and the panel works correctly, it should be doing the right thing. It will often write out that message due to the timing of when we receive the auth cookie, but it's typically a benign message. It's weird if you're not seeing it triggered, though. Most of the publisher sites are split into two separate scripts (and soon three), so it could possibly be that only one is receiving that?

jonathansampson · 2020-11-13T03:03:14Z

@emerick Tipping isn't working when I see this error; clicking the inline tipping button raises the following:

Failed to fetch tweet metadata for [object HTMLElement]: Error: Missing auth headers
    at api.ts:19
    at new Promise (<anonymous>)
    at sendAPIRequest (api.ts:11)
    at Module.getTweetDetails (api.ts:82)
    at getMediaMetaData (tipping.ts:22)
    at HTMLButtonElement.tipButton.onclick (tipping.ts:140)

emerick · 2020-11-13T03:11:27Z

@jonathansampson OK, gotcha - then it's definitely not what I was thinking. Do you mind creating a new issue with that info and the steps to repro that you mentioned earlier and we'll prioritize it? Thank you!

LaurenWags · 2020-11-18T19:53:11Z

Verified passed with

Brave | 1.17.70 Chromium: 87.0.4280.60 (Official Build) (x86_64)
-- | --
Revision | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS | macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#7141 (comment)

Opened multiple tabs w/ in-line tip buttons. Examples:

https://twitter.com/emerick, https://twitter.com/bravelaurenwags
Upgrade from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #12527 and other issue links
https://github.com/brave/brave-core/commits/master
12691: Improve the PR checklist. brave-core#7140 and other PR links
https://www.reddit.com/user/alex_the_brave, https://www.reddit.com/user/cryptojennie
https://old.reddit.com/
https://www.reddit.com/r/brave_browser/ and other subreddit links

Generally confirmed:

Navigating thru the various pages/page types above and confirming "Tip" text and button were displayed.
Opening new pages via context menu and confirming when opening the page it loaded and the "Tip" text and button were displayed.
Closing tabs and reopening using cmd+shift+T. When tab is reopened and loaded the "Tip" text and button were displayed.
Leaving various pages as active and then close/reopen the browser. On relaunch pages generally showed the "Tip" text and button, except for Twitter pages. This is logged with Greaselion script doesn't run when browser is launched with open tabs #11825. Reload fixes it. Also confirmed reloading a tab that was left over from previous session showed the "Tip" text and button once page loaded.

Verification passed on

Brave	1.17.70 Chromium: 87.0.4280.60 (Official Build) (64-bit)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#7141 (comment)

Opened multiple tabs w/ in-line tip buttons. Examples:

https://twitter.com/emerick, https://twitter.com/bravelaurenwags
Upgrade from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #12527 and other issue links
https://github.com/brave/brave-core/commits/master
12691: Improve the PR checklist. brave-core#7140 and other PR links
https://www.reddit.com/user/alex_the_brave, https://www.reddit.com/user/cryptojennie
https://old.reddit.com/ , encountered Make inline tipping icon clickable on old reddit #12611
https://www.reddit.com/r/brave_browser/ and other subreddit links

LaurenWags added bug feature/rewards intermittent-issue QA/Yes OS/Desktop labels Oct 21, 2020

LaurenWags mentioned this issue Oct 21, 2020

twitter tip button doesn't show on selected tweet when viewing thread #6762

Closed

bsclifton changed the title ~~[Desktop] race condition with greaselion and localizations~~ [Desktop] race condition with Greaselion and localizations Oct 26, 2020

LaurenWags mentioned this issue Oct 27, 2020

[Desktop] sometimes in-line tip button shows "twitterTipsIconLabel" text instead of "Tip" #12350

Closed

This was referenced Nov 5, 2020

[Desktop] no hover text for Tip button on Twitter #12536

Closed

[Desktop] Tip button on Reddit is missing hover color and text #12537

Closed

[Desktop] hover text is slightly misaligned on starred repos page of GitHub #12538

Closed

LaurenWags removed the intermittent-issue label Nov 10, 2020

btlechowski mentioned this issue Nov 10, 2020

Make inline tipping icon clickable on old reddit #12611

Closed

bbondy added the regression label Nov 10, 2020

emerick self-assigned this Nov 12, 2020

emerick mentioned this issue Nov 13, 2020

Store Greaselion extensions in user data dir and delete on exit brave/brave-core#7141

Merged

33 tasks

emerick added the release-notes/include label Nov 13, 2020

emerick closed this as completed in brave/brave-core#7141 Nov 16, 2020

emerick added this to the 1.19.x - Nightly milestone Nov 16, 2020

This was referenced Nov 17, 2020

Store Greaselion extensions in user data dir and delete on exit (uplift to 1.18.x) brave/brave-core#7165

Merged

Store Greaselion extensions in user data dir and delete on exit (uplift to 1.17.x) brave/brave-core#7166

Merged

kjozwiak modified the milestones: 1.19.x - Nightly, 1.17.x - Release Nov 18, 2020

LaurenWags added the QA Pass-macOS label Nov 18, 2020

LaurenWags mentioned this issue Nov 18, 2020

[Desktop] Release Notes for 1.17.x Release #2 (Release Channel) #12771

Closed

btlechowski added the QA Pass-Win64 label Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Desktop] race condition with Greaselion and localizations #12264

[Desktop] race condition with Greaselion and localizations #12264

LaurenWags commented Oct 21, 2020 •

edited

Loading

emerick commented Oct 21, 2020

GeetaSarvadnya commented Oct 22, 2020

LaurenWags commented Oct 28, 2020 •

edited

Loading

btlechowski commented Nov 4, 2020

LaurenWags commented Nov 4, 2020

LaurenWags commented Nov 10, 2020

emerick commented Nov 12, 2020 •

edited

Loading

jonathansampson commented Nov 13, 2020 •

edited

Loading

emerick commented Nov 13, 2020

jonathansampson commented Nov 13, 2020

emerick commented Nov 13, 2020

LaurenWags commented Nov 18, 2020 •

edited by btlechowski

Loading

[Desktop] race condition with Greaselion and localizations #12264

[Desktop] race condition with Greaselion and localizations #12264

Comments

LaurenWags commented Oct 21, 2020 • edited Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

emerick commented Oct 21, 2020

GeetaSarvadnya commented Oct 22, 2020

LaurenWags commented Oct 28, 2020 • edited Loading

btlechowski commented Nov 4, 2020

LaurenWags commented Nov 4, 2020

LaurenWags commented Nov 10, 2020

emerick commented Nov 12, 2020 • edited Loading

jonathansampson commented Nov 13, 2020 • edited Loading

emerick commented Nov 13, 2020

jonathansampson commented Nov 13, 2020

emerick commented Nov 13, 2020

LaurenWags commented Nov 18, 2020 • edited by btlechowski Loading

LaurenWags commented Oct 21, 2020 •

edited

Loading

LaurenWags commented Oct 28, 2020 •

edited

Loading

emerick commented Nov 12, 2020 •

edited

Loading

jonathansampson commented Nov 13, 2020 •

edited

Loading

LaurenWags commented Nov 18, 2020 •

edited by btlechowski

Loading