twitter tip button doesn't show on selected tweet when viewing thread

[LaurenWags]

Description

When you click on a tweet to view it/the associated thread, the selected tweet does not have the Tip button, but other tweets in the thread do.

Note - this works with the old twitter layout (when you're not logged in) but does not work with the newer twitter layout.

Steps to Reproduce

1. Clean profile
2. Enable Rewards
3. Navigate to twitter.com and login (logging in is important so you get the new layout)
4. Navigate to twitter.com/brave - note tweets have the Tip button.
5. Click on a tweet
6. Note tweet does not contain the tip button, but replies/tweets in the thread do.
7. Click on one of the replies
8. Note now this tweet does not contain the tip button, but other tweets in the thread do.

Actual result:

Step 6:

Step 8:

Expected result:

All tweets would have the tip button.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision	20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS	macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the dev channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

This is an existing issue in release version.
@kjozwiak also encountered this while testing

[NejcZdovc]

@LaurenWags is this still a problem on the latest nightly?

[LaurenWags]

yes, reproduces with

Brave	1.9.15 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision	32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS	macOS Version 10.14.6 (Build 18G3020)

[emerick]

It appears that this no longer works:

let tweets = document.querySelectorAll('[data-testid="tweet"], [data-testid="tweetDetail"]')

It used to find tweets in the regular stream (data-testid="tweet") and tweets in the detail view (data-testid="tweetDetail"). We would need to adjust the Twitter content script to account for the new HTML, possibly using the article role.

[jonathansampson]

Recently received a +1 on Twitter regarding this: https://twitter.com/brianoflondon/status/1261577925943611392

[LaurenWags]

Verified passed with

Brave | 1.17.45 Chromium: 86.0.4240.99 (Official Build) dev (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description. Confirmed main tweet shows Tip button.

Confirmed clicking on this button shows the appropriate twitter publisher and selected tweet on the tip banner:

Encountered and logged #12264

---

Verification passed on

Brave | 1.18.2 Chromium: 86.0.4240.111 (Official Build) nightly (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

• Verified STR from the description. Confirmed main tweet shows Tip button.
  

• Confirmed clicking on this button shows the appropriate twitter publisher and selected tweet on the tip banner:
  

Encountered #12264

---

Verification passed on

Brave	1.17.50 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

• Verified STR from the description.

• Confirmed main tweet shows Tip button.
  

• Confirmed clicking on this button shows the appropriate twitter publisher and selected tweet on the tip banner:
  

• Verified replies have Tip button