Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Greaselion extensions in user data dir and delete on exit (uplift to 1.18.x) #7165

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 17, 2020

Uplift of #7141
Resolves brave/brave-browser#12264
Resolves brave/brave-browser#12350

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team November 17, 2020 16:19
@brave-builds brave-builds self-assigned this Nov 17, 2020
@brave-builds brave-builds added this to the 1.18.x - Beta milestone Nov 17, 2020
@kjozwiak
Copy link
Member

Looks like test-browser failed a bunch of tests on Win x64 as per https://ci.brave.com/job/pr-brave-browser-pr7141_greaselion-localizations-race_1.18.x-windows/1/execution/node/246/log/. Going to restart to see if we can get some of them passing as we're still waiting for a new CR bump so we have some time.

13:59:01  2 tests failed:
13:59:01      RewardsBrowserTest.ActivateSettingsModal (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:121)
13:59:01      RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:232)
13:59:01  1 test timed out:
13:59:01      RewardsBrowserTest.BackupRestoreModalHasNotice (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:305)
13:59:01  1 test crashed:
13:59:01      RewardsBrowserTest.ToggleAutoContribute (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:132)

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-pr7141_greaselion-localizations-race_1.18.x-macos/1/execution/node/203/log/.

13:15:39  FAILED: obj/brave/common/extensions/api/generated_api_registration/generated_api_registration.o 

@kjozwiak
Copy link
Member

Restarting Win x64 due to issues losing the instance as per https://ci.brave.com/job/pr-brave-browser-pr7141_greaselion-localizations-race_1.18.x-windows/2/execution/node/199/log/.

18:06:20  Cannot contact i-0cb6715261ccfb8f4-windows-swarm-a3406d53: hudson.remoting.RequestAbortedException: java.nio.channels.ClosedChannelException
18:11:20  Could not connect to i-0cb6715261ccfb8f4-windows-swarm-a3406d53 to send interrupt signal to process

@kjozwiak
Copy link
Member

test-browser failed on macOS due to both RewardsBrowserTest.UpholdLimitNoBAT & RewardsPromotionBrowserTest.ClaimViaSettingsPage failing as per https://ci.brave.com/job/pr-brave-browser-pr7141_greaselion-localizations-race_1.18.x-macos/2/execution/node/250/log/. However, these are known intermittent issues and don't block uplifting.

19:02:08  2 tests failed:
19:02:08      RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:399)
19:02:08      RewardsPromotionBrowserTest.ClaimViaSettingsPage (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:197)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7141 (comment).

@kjozwiak kjozwiak merged commit 47a45cf into 1.18.x Nov 18, 2020
@kjozwiak kjozwiak deleted the pr7141_greaselion-localizations-race_1.18.x branch November 18, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants