[Desktop] sometimes in-line tip button shows "twitterTipsIconLabel" text instead of "Tip"

[LaurenWags]

Description

Sometimes the in-line tip button displays "twitterTipsIconLabel" instead of "Tip" text (localized).

I haven't been able to reproduce this but it has been reported internally and externally.

Steps to Reproduce

TBD

Actual result:

Expected result:

Reproduces how often:

unsure

Brave version (brave://version info)

unknown

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @emerick

[LaurenWags]

I've tried variations on the following without success:

1. Install older version (1.15.x), enable Rewards. Upgrade to 1.16.x (no Twitter greaselion tipping). Close/open twitter pages. Could not reproduce this issue but did reproduce [Desktop] race condition with Greaselion and localizations #12264.
2. Install older version (1.15.x), enable Rewards. Upgrade to 1.17.x (with Twitter greaselion tipping). Close/open twitter pages. Could not reproduce this issue but did reproduce [Desktop] race condition with Greaselion and localizations #12264.
3. Install 1.16.x and 1.17.x, enable Rewards. Open twitter page (like twitter.com/brave). Close/reopen browser several times to see if I could produce a race condition. Was unsuccessful but did reproduce already logged issue [Desktop] race condition with Greaselion and localizations #12264.
4. Repeat above cases using non-US, non-English locale & language.

[BrendanEich]

Dup of #12264 or same underlying cause?

[jonathansampson]

Users are seeing this in 1.16.68 (current Release at the time of this writing) [1][2]. One user reported the issue has having resolved itself after a short period of time.

I just switched over to another GitHub tab (which I hadn't visited since launching the browser, IIRC) to find this:

[LaurenWags]

Verified passed with

Brave | 1.17.70 Chromium: 87.0.4280.60 (Official Build) (x86_64)
-- | --
Revision | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS | macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#7141 (comment)

Opened multiple tabs w/ in-line tip buttons. Examples:

• https://twitter.com/emerick, https://twitter.com/bravelaurenwags
• Upgrade from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #12527 and other issue links
• https://github.com/brave/brave-core/commits/master
• 12691: Improve the PR checklist. brave-core#7140 and other PR links
• https://www.reddit.com/user/alex_the_brave, https://www.reddit.com/user/cryptojennie
• https://old.reddit.com/
• https://www.reddit.com/r/brave_browser/ and other subreddit links

Generally confirmed:

• Navigating thru the various pages/page types above and confirming "Tip" text and button were displayed.
• Opening new pages via context menu and confirming when opening the page it loaded and the "Tip" text and button were displayed.
• Closing tabs and reopening using cmd+shift+T. When tab is reopened and loaded the "Tip" text and button were displayed.
• Leaving various pages as active and then close/reopen the browser. On relaunch pages generally showed the "Tip" text and button, except for Twitter pages. This is logged with Greaselion script doesn't run when browser is launched with open tabs #11825. Reload fixes it. Also confirmed reloading a tab that was left over from previous session showed the "Tip" text and button once page loaded.

---

Verification passed on

Brave	1.17.70 Chromium: 87.0.4280.60 (Official Build) (64-bit)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#7141 (comment)

The text always shows Tip, rather than twitterTipsIconLabel

Opened multiple tabs w/ in-line tip buttons. Examples:

• https://twitter.com/emerick, https://twitter.com/bravelaurenwags
• Upgrade from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #12527 and other issue links
• https://github.com/brave/brave-core/commits/master
• 12691: Improve the PR checklist. brave-core#7140 and other PR links
• https://www.reddit.com/user/alex_the_brave, https://www.reddit.com/user/cryptojennie
• https://old.reddit.com/ , encountered Make inline tipping icon clickable on old reddit #12611
• https://www.reddit.com/r/brave_browser/ and other subreddit links

[cryptojennie]

I'm still running into the twitterTipsIconLabel issue intermittently after updating to v1.17.73.

Version info: v1.17.73 Chromium: 87.0.4280.67 (Official Build) (x86_64)
OS: MacOS Catalina

[LaurenWags]

QA process is to log a new issue once an issue is closed with a PR, so closing this one. We can track the new issue under #12900.