Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #12527

Closed
mkarolin opened this issue Nov 5, 2020 · 4 comments · Fixed by brave/brave-core#7061 or #12528
Closed

Upgrade from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #12527

mkarolin opened this issue Nov 5, 2020 · 4 comments · Fixed by brave/brave-core#7061 or #12528

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Nov 5, 2020

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/87.0.4280.47..87.0.4280.49?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

No specific code changes in Brave (only line number changes in patches).

@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2020

Ensure that the sections that @mkarolin mentioned via #11534 (comment) are checked.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 9, 2020

Verified passed with

Brave	1.17.63 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	macOS Version 10.14.6 (Build 18G6032)

Verified updated Chromium version on brave://version.
Verified sections mentioned in #11534 (comment)

  • Confirmed brave://rewards page displays as expected. Confirmed able to join rewards from brave://rewards. Confirmed able to modify settings and settings were retained on restart.
  • Confirmed brave://welcome page displays as expected. Confirmed able to navigate thru the slide without error. Confirmed able to interact with the slides without error.
  • Confirmed able to import using brave://settings/importData. Confirmed able to select different input from the drop list as well as check/uncheck boxes to control what is imported.
  • Confirmed brave://settings displayed as expected. Confirmed able to change various settings and selections were retained on restart. Opened various settings sub pages (ex. brave://settings/passwords, brave://settings/braveSync/setup, etc) and confirmed they opened without issue.
  • Confirmed able to set SE via brave://welcome, brave://settings/search, and brave://settings/searchEngines. Confirmed selected SE is retained on restart.

Screen Shot 2020-11-09 at 7 02 43 AM

Full manual pass will be completed with #12409.


Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified updated Chromium version on brave://version.
Verified sections mentioned in #11534 (comment)

  • Confirmed brave://rewards page displays as expected. Confirmed able to join rewards from brave://rewards. Confirmed able to modify settings and settings were retained on restart.
  • Confirmed brave://welcome page displays as expected. Confirmed able to navigate thru the slide without error. Confirmed able to interact with the slides without error.
  • Confirmed able to import using brave://settings/importData. Confirmed able to select different input from the drop list as well as check/uncheck boxes to control what is imported.
  • Confirmed brave://settings displayed as expected. Confirmed able to change various settings and selections were retained on restart. Opened various settings sub pages (ex. brave://settings/passwords, brave://settings/braveSync/setup, etc) and confirmed they opened without issue.
  • Confirmed able to set SE via brave://welcome, brave://settings/search, and brave://settings/searchEngines. Confirmed selected SE is retained on restart.

image

Full manual pass will be completed.


Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Ubuntu 18.04 LTS

Verified updated Chromium version on brave://version.
image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.17.66 x64 beta build

  • Verified Android applicable sections mentioned from Upgrade from Chromium 86 to Chromium 87. #11534 (comment)
  • Verified able to create a wallet without issues
  • Verified able to change rewards settings and retain it between relaunches
  • Verified able to change SE and retain it between relaunches
  • Verified setting changes are retained across relaunches
    image

Verification passed on Samsung Tab A with Android 10 running 1.17.66 x64 beta build

  • Verified Android applicable sections mentioned from Upgrade from Chromium 86 to Chromium 87. #11534 (comment)
  • Verified able to create a wallet without issues
  • Verified able to change rewards settings and retain it between relaunches
  • Verified able to change SE and retain it between relaunches
  • Verified setting changes are retained across relaunches
    image

@LaurenWags
Copy link
Member

re-labeling as release-notes/exclude as this is superseded by #12676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment