Updated patches from Chromium 87.0.4280.47 to Chromium 87.0.4280.49. #7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
Chromium change: https://source.chromium.org/chromium/chromium/src/+/af730955 commit af7309559feae76c9f3368006c80f1290454c46a Author: Yue Zhang <yuezhanggg@chromium.org> Date: Tue Nov 3 18:08:16 2020 +0000 Hide tab strip when omnibox has focus Since TabGridDialog and omnibox both use the ScrimView from RootUiCoordinator, there will be a conflict when user try to open dialog from tab strip when omnibox is focused. This CL fixes this issue by suppressing tab strip when omnibox is focused and restoring visibility when omnibox loses focus. (cherry picked from commit 6630c45c96c137a767cbe345d34b61d3bd65cd79) Bug: 1096358
mkarolin
added
CI/skip-ios
|
A known CI failure on Windows ( Build failure on Android. |
|
@samartnik, could you please review the Android change: ef402fd |
|
@samartnik, pushed a change to remove the bytecode patching. |
|
Android passed CI. |
mkarolin
pushed a commit
that referenced
this pull request
Nov 7, 2020
Updated patches from Chromium 87.0.4280.47 to Chromium 87.0.4280.49.
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#12527
Related PR: brave/brave-browser#12528
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.