Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 86 to Chromium 87. #6554

Merged
merged 152 commits into from
Oct 28, 2020
Merged

Upgrade from Chromium 86 to Chromium 87. #6554

merged 152 commits into from
Oct 28, 2020

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#11534
Related PR: brave/brave-browser#11535

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Aug 31, 2020
@mkarolin mkarolin changed the title Upgrade from Chromium 86 to Chromium 87. WIP: Upgrade from Chromium 86 to Chromium 87. Oct 15, 2020
@mkarolin mkarolin marked this pull request as ready for review October 15, 2020 20:48
mkarolin and others added 19 commits October 28, 2020 14:04
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/03a3886037b487217478029bb7fa64271ac386c1

commit 03a3886037b487217478029bb7fa64271ac386c1
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date:   Fri Sep 18 05:19:16 2020 +0000

    Enable SignedExchangeSubresourcePrefetch at tip of tree

    Intent to ship:
    https://groups.google.com/a/chromium.org/g/blink-dev/c/tybtqf-tdB4/m/PSNj5vSEAwAJ

    Bug: 935267
Additionally, replaced passwords_section.html patch with a js override.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/acf8f136ea77dc40f03f907aeb8b32cb4d30aa6f

commit acf8f136ea77dc40f03f907aeb8b32cb4d30aa6f
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date:   Thu Sep 10 16:00:13 2020 +0000

    [Passwords] Remove conditional Password Check logic for Desktop

    This change removes Desktop only code checking the state of the
    Password Check feature flag. This feature is fully launched on Desktop,
    and the flag should be removed eventually. For now we keep it around,
    because we use it in cross-platform code to guard the implementations
    on mobile.

    Bug: 1049177, 1126051
Reverted previous commit as error was related to sccache
We don't need it anymore as DCHECK, for which it was added, is no longer
in Chromium's code.
Cr87 code review.

The patches are not needed because rlz_enabled is gated on
is_chrome_branded which we set to false.
This reverts commit f42f9b0.

We will not support history import from safary as chrome doesn't support it.
This reverts commit 0281499.

We will not support history import from safari as chrome doesn't support it.
brave_theme_helper_win.cc/h were moved out into sources.gni by
#6887
Fixes the error in CustomToolbar that menu is shown from bottom.

Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/ad4cf0623574d9d7ea517d0063cb054d98766964

Duet: Clean up unused classes and resources

Delete all the classes and resources left unused by
Duet (BottomToolbar).

Bug: 1081343
@mkarolin
Copy link
Collaborator Author

CI browser test failures:

@mkarolin mkarolin merged commit bf84b94 into master Oct 28, 2020
@mkarolin mkarolin deleted the cr87 branch October 28, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 86 to Chromium 87.
10 participants