Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 86 to Chromium 87. #11535

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Upgrade from Chromium 86 to Chromium 87. #11535

merged 1 commit into from
Oct 28, 2020

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Aug 31, 2020

Fixes #11534
Related PR: brave/brave-core#6554

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin changed the title Upgrade from Chromium 86 to Chromium 87. WIP: Upgrade from Chromium 86 to Chromium 87. Oct 15, 2020
@mkarolin mkarolin marked this pull request as ready for review October 15, 2020 20:47
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 86 to Chromium 87. Upgrade from Chromium 86 to Chromium 87. Oct 20, 2020
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but need to fix branch

package.json Outdated
"repository": {
"url": "https://github.com/chromium/chromium"
}
},
"brave-core": {
"dir": "src/brave",
"branch": "master",
"branch": "cr87",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to change this back to master

@mkarolin mkarolin merged commit 98fd3cb into master Oct 28, 2020
@mkarolin mkarolin deleted the cr87 branch October 28, 2020 22:52
@mkarolin mkarolin added this to the 1.18.x - Nightly milestone Oct 30, 2020
mkarolin added a commit that referenced this pull request Nov 7, 2020
Upgrade from Chromium 86 to Chromium 87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 86 to Chromium 87.
5 participants