Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu buttons alignment is wrong on CR87 #12483

Closed
srirambv opened this issue Nov 3, 2020 · 5 comments · Fixed by brave/brave-core#7055 or brave/brave-core#7120
Closed

Menu buttons alignment is wrong on CR87 #12483

srirambv opened this issue Nov 3, 2020 · 5 comments · Fixed by brave/brave-core#7055 or brave/brave-core#7120

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 3, 2020

Description

Menu buttons alignment is wrong on CR87

Steps to reproduce

  1. Install 1.18.27 x64 nightly build
  2. Open menu
  3. Buttons are on the top of flyout menu rather than bottom

Result

Actual Expected
image image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.18.27

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv
Copy link
Contributor Author

srirambv commented Nov 3, 2020

Can't repro it all the time. Happened on upgrade once as well

@samartnik
Copy link
Contributor

I wasn't able to reproduce, applied possible fix with proper default value for bottom toolbar

@srirambv
Copy link
Contributor Author

Found the root cause of the issue. Happens when you disable bottom toolbar and skip on restarting browser.
menu

Reopening the issue and moving out of milestone. @samartnik please close the issue if you feel its invalid.

@srirambv
Copy link
Contributor Author

This still isn't fixed. Menu buttons alignment is still off when disabling bottom toolbar but seems fixed for enabling

@LaurenWags
Copy link
Member

Verification passed on LG Nexus 5 with Android 5.1 running 1.18.67 Bravearm.apk


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment