Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Changed default value for menu from bottom #7055

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Nov 4, 2020

Resolves brave/brave-browser#12483

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 4, 2020
@samartnik samartnik added this to the 1.18.x - Nightly milestone Nov 4, 2020
@samartnik samartnik self-assigned this Nov 4, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit 356ff84 into master Nov 4, 2020
@samartnik samartnik deleted the android_menu_buttons branch November 4, 2020 21:31
mkarolin pushed a commit that referenced this pull request Nov 7, 2020
[Android] Changed default value for menu from bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu buttons alignment is wrong on CR87
2 participants