Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong text for link in Private Window with Tor New tab #1263

Closed
btlechowski opened this issue Sep 24, 2018 · 1 comment · Fixed by brave/brave-core#542
Closed

Wrong text for link in Private Window with Tor New tab #1263

btlechowski opened this issue Sep 24, 2018 · 1 comment · Fixed by brave/brave-core#542

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Open New tab in Private Window with Tor

Actual result:

Link is chrome://settings/search
text is Learn more

image

Expected result:

Link is chrome://settings/search
text is Search Preferences

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Reproducible on current release:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

@srirambv @kjozwiak @LaurenWags @bsclifton @GeetaSarvadnya @cezaraugusto

Similar issue to #1262, but because these are two different pages, I opened a new issue

@btlechowski
Copy link
Author

btlechowski commented Oct 9, 2018

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

image

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

image

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

screen shot 2018-10-10 at 10 16 45 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment