Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement onboarding for P3A on Android #12723

Closed
AlexeyBarabash opened this issue Nov 16, 2020 · 8 comments · Fixed by brave/brave-core#7550
Closed

Implement onboarding for P3A on Android #12723

AlexeyBarabash opened this issue Nov 16, 2020 · 8 comments · Fixed by brave/brave-core#7550
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/user-interface All UI related features/P3A onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Nov 16, 2020

Description

The follow up issue for #6176 . It is required to implement notification about P3A during onboarding as it is done for desktop.

Designs

For new users, show an initial welcome screen with P3A checkbox before the privacy onboarding experience:

loadingP3A

(This has the same Brave logo animation as in the first version of onboarding.)

image

For new users who viewed the onboarding message p3a.enabled should be true, p3a.notice_acknowledged should be true

For existing users, show the P3A checkbox modal on next app launch:

image

The P3A checkbox modal takes priority over any other modals that might be in queue (for example, set Brave as default browser).

"Private product analytics" links to https://brave.com/p3a

Assets

Figma: https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/?node-id=1511%3A24317

@AlexeyBarabash AlexeyBarabash added feature/user-interface All UI related design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality features/P3A labels Nov 16, 2020
@karenkliu
Copy link

Designs added!

@AlexeyBarabash
Copy link
Contributor Author

awesome, thanks @karenkliu

@deeppandya
Copy link

@karenkliu is the checkbox is clickable here ? if it is, then what should happen when user unselect the check box ?

@karenkliu
Copy link

karenkliu commented Jan 6, 2021

@deeppandya The user can tap on the checkbox to unselect it. If unselected, p3a.enabled should be false, p3a.notice_acknowledged should be true

Checkbox spec is here: https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=105%3A244 (use Roboto for the text but try to match checkbox color and style)

@bsclifton
Copy link
Member

bsclifton commented Jan 11, 2021

@deeppandya can we close #6688 as a duplicate? This has more details

Basically, we need to cover the new user (onboarding) case - but also the case where user is already an existing user. If you want, you can edit/use #6688 to cover the existing user case

@deeppandya
Copy link

@bsclifton I think this issue has covered both scenarios. I will close the other issue

@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2021

Verification passed on OnePlus 6T with Android 10 running 1.20.100 x64 build

  • Verified P3A onboarding is shown on a clean install
  • Verified opt-in or opt-out on a clean install shows privacy stats onboarding immediately after P3A is dismissed
  • Verified onboarding is shown on an upgrade profile
  • Verified P3A metrics are captured based and sets value based on https://github.com/brave/brave-browser/wiki/P3A

Verification passed on Samsung Tab A with Android 10 running 1.20.100 x64 build

  • Verified P3A onboarding is shown on a clean install
  • Verified opt-in or opt-out on a clean install shows privacy stats onboarding immediately after P3A is dismissed
  • Verified onboarding is shown on an upgrade profile
  • Verified P3A metrics are captured based and sets value based on https://github.com/brave/brave-browser/wiki/P3A

@deeppandya
Copy link

How can I change this setting again?

@newuser-web you can change it from settings-> Privacy. Screenshot_20210214-222739.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/user-interface All UI related features/P3A onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
5 participants