-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement onboarding for P3A on Android #12723
Comments
Designs added! |
awesome, thanks @karenkliu |
@karenkliu is the checkbox is clickable here ? if it is, then what should happen when user unselect the check box ? |
@deeppandya The user can tap on the checkbox to unselect it. If unselected, Checkbox spec is here: https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=105%3A244 (use Roboto for the text but try to match checkbox color and style) |
@deeppandya can we close #6688 as a duplicate? This has more details Basically, we need to cover the new user (onboarding) case - but also the case where user is already an existing user. If you want, you can edit/use #6688 to cover the existing user case |
@bsclifton I think this issue has covered both scenarios. I will close the other issue |
Verification passed on OnePlus 6T with Android 10 running 1.20.100 x64 build
Verification passed on Samsung Tab A with Android 10 running 1.20.100 x64 build
|
@newuser-web you can change it from settings-> Privacy. |
Description
The follow up issue for #6176 . It is required to implement notification about P3A during onboarding as it is done for desktop.
Designs
For new users, show an initial welcome screen with P3A checkbox before the privacy onboarding experience:
(This has the same Brave logo animation as in the first version of onboarding.)
For new users who viewed the onboarding message
p3a.enabled
should betrue
,p3a.notice_acknowledged
should betrue
For existing users, show the P3A checkbox modal on next app launch:
The P3A checkbox modal takes priority over any other modals that might be in queue (for example, set Brave as default browser).
"Private product analytics" links to
https://brave.com/p3a
Assets
Figma: https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/?node-id=1511%3A24317
The text was updated successfully, but these errors were encountered: